Angular Acquisitions Sprint 1: Providers

Bug #1857150 reported by Andrea Neiman on 2019-12-20
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned

Bug Description

This work is sponsored by the Evergreen Community Development Initiative (formerly MassLNC).

Next on the calendar for the Angular Acquisitions project is the Providers interfaces.

This work will rewrite the Acquisitions Providers search, create, edit, and display interfaces to Angular. The legacy Dojo interfaces will be removed as appropriate.

The approved specification can be seen here:
https://yeti.esilibrary.com/dev/public/techspecs/angacq_sprint1_final.pdf

Andrea Neiman (aneiman) on 2019-12-20
description: updated
Galen Charlton (gmc) on 2020-09-03
Changed in evergreen:
milestone: none → 3.6-beta
assignee: nobody → Galen Charlton (gmc)
Galen Charlton (gmc) wrote :

A branch is available for review at

working/user/gmcharlt/lp1857150-angular-providers-v1 /
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1857150-angular-providers-v1

tags: added: pullrequest
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Ruth Frasur (rfrasur) wrote :

I have tested this code and consent to signing off on it with my name, rfrasur and my email address, <email address hidden>.

tags: added: signedoff
John Amundson (jamundson) wrote :

Although I unfortunately do not have a way to install the most recent branch to test locally, there are still some issues that I see on the provider-test server that I noted on 9/1/20 and confirmed still exist.

Here is what I see when trying to single-click a provider's entry.

Main issue: If a tab is chosen outside of the "Provider" tab, then the data from the previously chosen provider persists.

And related, but not as pressing, the default tab is not respected when single-clicking.

To test main issue:
1. Perform a search for CONS+desc to grab all providers.
2. Single-click on "Amazon".
3. Click on the tab for "Contacts" and note Amazon's contact info.
4. From the search results, select any other provider. Note that the Amazon contact details persist.
5. Repeat step 4 to your heart's content.

This does not appear to happen on the Provider tab but does on others, not just limited to Contacts.

I have also confirmed that "Retrieve Provider" works for a single provider, however, if multiple providers are checked, the action only brings back the first provider selected. In a perfect world, the action should open new tabs for each provider. That is probably an enhancement, so instead the action should probably be greyed out if multiple providers are selected.

Ruth Frasur (rfrasur) wrote :

From retesting based on John's observations, I retested this and do see what he's observed.

I tested this both as admin and br3snyder (concerto acq staff profile). The following is from the br3snyder test. Workstation set at br3.

1. Performed search for BR3+anc+desc.
2. Single-click on Baker and Taylor Adult Fiction.
3. Click on contacts. This hides the search form.
4. Click "Show Search Form" and repeat BR3+anc+desc search. Search results appear, and Baker and Taylor Adult Fiction record appears below it.
5. Single-click on another provider and, while the summary box is updated, the contacts tab remains open and retains the information from the initial search. Clicking on the provider tab shows updated information. THEN clicking on the contacts tab shows updated information.

Andrea Neiman (aneiman) wrote :

Follow up bug 1894148 to open Providers in new tabs - though we'll take a look at the issue described with sticky info on the contacts tab.

Galen Charlton (gmc) wrote :

After some discussion with Ruth, I've posted a new branch:

working/user/gmcharlt/lp1857150-angular-providers-v2 /
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1857150-angular-providers-v2

This changes the single-click behavior to fully retrieve the provider (and navigate to the selected default tab) while not hiding the search form (rather than just updating the summary). The double-click and 'Retrieve Provider' action continue to act as before: retrieve the provider and hide the search form.

Ruth Frasur (rfrasur) wrote :

I've verified this fix.

John Amundson (jamundson) wrote :

Thank you, Galen!

The new behavior looks really good.

John

Galen Charlton (gmc) on 2020-09-09
Changed in evergreen:
status: New → Confirmed
Bill Erickson (berick) on 2020-09-10
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
assignee: Bill Erickson (berick) → nobody
Bill Erickson (berick) on 2020-09-10
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Bill Erickson (berick) wrote :

Here's a branch with mine and Ruth's signoff's added. Code and UI reviewed and tested. I made no additional changes. +1 for merge from my perspective.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1857150-angular-providers

Note while testing these interfaces the only concern I had were the grid filters. It's a lot to take in and they are bursting at the seams. I added a comment to bug #1846042 to hopefully get some movement on that.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Jason Etheridge (phasefx) wrote :

Looks good to me, just two minor things I'll open bugs for. Pushed to master!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers