Comment 15 for bug 1855780

I've skimmed this and it looks good as far as it goes, but unless I'm missing something, there's a pretty big omission: there's no way to set an event definition's environment and parameters and there's no equivalent of the Dojo event definition test. In the Dojo interface, these three bits are accessed by clicking on the linked definition title (as opposed to double-clicking on the row to open the main editing modal).

I'm tacking on the needsrepatch tag on this, but to be clear, I think the current patch is a very solid start.

The most direct way to deal with the missing bits might be to add grid actions to edit the environment, edit the parameters, and run the tests. Alternatively, having the main edit modal (possibly by adding tabs?) be able to handle the environment and parameters would be an UX improvement, but would be a bit more work.

Also noting that the recent upgrade to Angular 10 means that the loadChildren attribute will need to be updated. It would also be good to replace ngbTab with ngbNav.