Typo when creating new carousel mapping

Bug #1855761 reported by Terran McCanna
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned

Bug Description

In 3.4.1 - When manually creating a new carousel mapping, the success alert has a typo - "succeesfully"

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Here's the code where one might fix this, by the way: https://github.com/evergreen-library-system/Evergreen/blob/master/Open-ILS/src/eg2/src/app/staff/admin/local/admin-carousel.component.html#L18

It looks like there's another typo in this interface on line 12: "Delete of carousel faiiled or was not allowed" -- "faiiled" should be "failed"

Michele Morgan (mmorgan)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Terran McCanna (tmccanna) wrote :
tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.6.1
Revision history for this message
Terran McCanna (tmccanna) wrote :

Found another typo - pushed this along with previous typo fix here (top 2 commits):

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1855761_carousel_message_typos2

Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Revision history for this message
Michele Morgan (mmorgan) wrote :

Here's a signoff branch with an additional commit to address two more occurrences of "Succeessfully":

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1866761_signoff_and_typos3

Credit also goes to Christine Morgan and Martha Driscoll for working on this. This was our test bug for hammering out a process to update and test Angular components.

Adding a signedoff tag, though, technically, the last commit needs another one.

tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Terran and Michele. Pushed to master and rel_3_6.

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.