Angular Perm Group UI Mapping Modal Fails to load on null perm description

[Chris Sharp]

When creating a new perm/group mapping in Administration -> Server Administration -> Permission Group, upon clicking on a Permission Group, then the Group Permissions tab, then Add New Mapping, then clicking within the New Permission box, the perm list fails to load with the following error:

ERROR TypeError: "l.description(...) is null"

PINES had 20 perms without descriptions. Adding descriptions to these solved the problem. Ideally, some defensive coding would be added to accommodate this possibility, but the most straightforward thing to do is to add the perm descriptions, which I will create a branch to do.

Evergreen 3.4.1
OpenSRF 3.1
PostgreSQL 10
Ubuntu 16.04

[Chris Sharp (chrissharp123)]

Branch available here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1851831_force_perm_descriptions

[Bill Erickson (berick)]

Issue also occurs in the permissions filter input. Branch to add defensive coding underway.

[Bill Erickson (berick)]

Fixes pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1851831-perm-grp-null-desc

This repairs 3 cases where a description was assumed to exist. Two caused JS errors and one resulted in empty title attributes in the permission list.

[Chris Sharp (chrissharp123)]

Bill's fix is confirmed working. Pushed to master and rel_3_4. Thanks for the quick fix, Bill!