Booking: port Capture Resources screen to Angular

[Jane Sandberg]

All of the booking module is now in Angular, except for the dojo Capture Resources screen. This screen was not part of bug 1816475, since it needed to be able to print a hold slip for the captured resource.

Now that we have server-managed print templates in Angular (bug 1825851), we can port the Capture Resources screen too. "Capture Resources" might also make a good action for some grids in other booking screens, like Manage Reservations or Pick Up Reservations.

I will tentatively plan to do this for 3.5, but if somebody else wants to take this on, please feel free to un-assign me.

[Jane Sandberg (sandbergja)]

Here's a branch that ports the capture resources screen to Angular: user/sandbergja/lp1851306_port_booking_capture_to_angular

Here's a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1851306_port_booking_capture_to_angular

Let me know what you think!

[Bill Erickson (berick)]

Hi Jane, took a very quick look at this today. 2 things caught my eye, a few untranslatable toast strings and a JS error that is consistently logged on page load:

CaptureComponent.html:10 ERROR TypeError: this.reloadGrid is not a function
    at ReservationsGridComponent.ngOnChanges (reservations-grid.component.ts:299)

[Jane Sandberg (sandbergja)]

Thanks for catching those, Bill. I force-pushed fixes to those issues to the same branch.

[Terran McCanna (tmccanna)]

I tested on a 3.4 master server with concerto data and it worked for me. My sign off at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1851306_port_booking_capture_to_angular_signoff

[Galen Charlton (gmc)]

Pushed to master for inclusion in 3.6 along with a couple follow-ups. Thanks, Jane and Terran!