Angular catalog results display efficiency improvements

Bug #1849523 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
New
Undecided
Unassigned

Bug Description

Evergreen 3.4

The results display of the Angular catalog could use a few efficiency improvements.

1. The hold counts API call is made for each record retrieved. This could be batched to reduce network calls. As it stands, the result list displays 20 records at a time. That's 20 API calls that could be reduced to 1 (or 2, see below).

2. Because of the way records and related data are retrieved in batch, the results page often has no data to show until all 20 records are retrieved and fleshed out. Breaking the results retrieved into 2 batches (e.g. start with 5 records, then fetch the rest) allows the UI to start producing usable / displayable data earlier in the rendering process.

Suggestions welcome. Patch en route.

Revision history for this message
Bill Erickson (berick) wrote :

Patches pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1849523-ang-cat-display-efficiency

This reduces the per-page API count from 21 to 3 while still providing quick turnaround for the first set of results.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.4.1
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
milestone: 3.4.1 → 3.4.2
Bill Erickson (berick)
tags: added: performance
Bill Erickson (berick)
tags: added: staffcatalog
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Revision history for this message
Jennifer Weston (jweston) wrote :

Verified increase speed of returning search results. Used kcls sandbox during feedback fest and was able to see results for all books in less than 2 seconds. Subsequent searches with other variables demonstrated similar results.

I am not sure if a developer eye is needed to confirm actual API call performance so not adding signoff tag at the moment. I am happy to confirm my testing was successful from end-user search perspective.
Jennifer Weston, <email address hidden>

Changed in evergreen:
milestone: 3.4.3 → 3.4.4
Revision history for this message
Bill Erickson (berick) wrote :

Marking this as duplicate of bug #1889694 which will improve a number of data retrieval issues including the items listed in this bug.

tags: removed: pullrequest
Changed in evergreen:
milestone: 3.4.4 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.