angular: modals do not automatically close when navigating away from pages

[Andrea Neiman]

3.4 (probably all new Angular interfaces)

If you have a modal open in a new Angular interface and click the back/forward browser buttons, the modal persists over the (unrelated) pages until you hit an AngularJS interface.

[Bill Erickson (berick)]

Fix pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1849372-ang-route-close-dialog

To test:

[1] Navigate to Server Administration
[2] Navigate to Age Hold Protection Rule Configuration
[3] Double-click a grid row to open an edit dialog
[4] Click browser back button to return to the Server Admin page
[5] Confirm edit dialog closes once the navigation is complete.

[Galen Charlton (gmc)]

Tested and signed off: user/gmcharlt/lp1849372_signoff

I note that there is a possible enhancement: rather than unconditionally dismissing the modal, it could be handle to allow an open modal prevent or override navigation if it has a dirty state. In that case, the page that is displaying the modal should display a toast or some other way of telling the user why navigation is being blocked.

[Mike Rylander (mrylander)]

I've picked this into master, 3.4, and because it came in cleanly, into 3.3. 3.2 was not a clean merge, so I've left it out.

Thanks, Bill and Galen!