Regression - Preferred Lib search inclusion for Located URI results

[Josh Stompro]

EG 3.3.4

The feature that enables search to included located URI's from the pref_lib when it is outside of the search scope didn't make it into the "Eliminate staged search" Bug #1698206

The feature was added in bug #975577, "Preferred library should affect search scope for located URIs"

We rely on that behavior since we are a consortium of two regional library systems that share all physical items, but have separate overdrive subscriptions. If the catalog is setup to indicate a default pref_lib for non logged in users (setenv physical_loc) or using the home library for logged in users for the pref_lib, then we only want those users to see the scoped electronic records that they can actually access. Even if the user changes their search scope to the other system.

Thanks
Josh

[Josh Stompro (u-launchpad-stompro-org)]

I was able to simply push the pref_lib ou and ancestors onto the luri_org visibility test in Application/Storage/Driver/Pg/QueryParser.pm as a proof of concept which solves our biggest pain point right now.

With that change, even when the search scope is CONS, as long as the pref_lib is set to the region or home_ou then ebooks show up for the user.

I think that was the behavior from bug #975577.

Going further though, would be to just replace the search scope orgs for luris with the pref_lib if it is set, which would make sure that users couldn't see ebooks that were out of scope for their catalog views.

But I don't know if that is actually needed, our users so rarely change their search scope... And then there would be no possible way for staff to see ebooks in the catalog for other systems.

Josh

[Josh Stompro (u-launchpad-stompro-org)]

Here is a branch that restores the functionality of bug #975577.

user/stompro/lp1849161_pref_ou_luri_search
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1849161_pref_ou_luri_search

Josh