Angular staff catalog record detail "Patron View" tab

[Bill Erickson]

Evergreen 3.4 / Wishlist

The Angular staff catalog could make seeing the patron view of a record a little more streamlined. Proposal is to replace (or possibly augment) the "View In Catalog" button with a "Patron View" tab in the record detail page. This tab would show an embedded view of the patron OPAC record detail page. In addition to not requiring a new tab, it allows staff to page through OPAC views via the staff catalog search results next/previous links in line with the rest of the catalog page.

My plan for now is to simply display the record detail page without propagating the search query or creating any tie-ins / script handlers to the iframe. It will simply be an iframe with a source. This could evolve if needed.

[Bill Erickson (berick)]

Branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1849137-ang-cat-opac-view-tab

[Garry Collum (gcollum)]

Tested and works as advertised. Signed-off at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1849137-ang-cat-opac-view-tab-signoff

[Galen Charlton (gmc)]

I looked at this during the hack-a-way but didn't get around to commenting. I think there are a couple usability issues that mirror similar experiences embedding the public catalog in the AngularJS staff interface:

[1] The iframe has an internal scrollbar, which I know was the topic of many bug reports with various embedded interfaces in the AngularJS client.
[2] All of the OPAC buttons and actions are active, which means that somebody could potentially really confuse themselves by doing things like place holds. Perhaps the OPAC buttons could be disabled when embedded in this context?

[Bill Erickson (berick)]

I'm looking into Galen's comments now...

[Bill Erickson (berick)]

Stealing bug from Jane.

[Bill Erickson (berick)]

New branch pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1849137-ang-cat-opac-view-tab-2

Includes Garry's sign-off. (Thanks, Garry!)

Adds another commit, from the notes: ---

Adds a readonly record detail view to the OPAC. This is used by the Angular catalog Patron View tab to present a version of the OPAC where all links, buttons, and inputs are disabled.

Dynamically style the height of the embedded iframe to prevent nested scroll bars in the Patron View.

[Jane Sandberg (sandbergja)]

Thanks for this, Bill. It looks really good! A few thoughts:

1) While the iframe content is loading, all I see is an empty white box. I could see this being confusing for users, especially if loading takes a while. Could you please add some sort of wait indicator or progress indicator while the content is loading?

2) This is not a blocker at all, but I suspect that anything above the title is not needed -- the header, nav links, and disabled search bar won't be that much use for catalogers. Could we get rid of these?

[Jane Sandberg (sandbergja)]

Actually, two more:

* I find the Shelf Browser super helpful when cataloging, and it would be great to have easy access to it. Maybe the Shelf Browser record details could be open instead of closed in readonly mode? Or maybe there could be an easier way to get to the Angular shelf browse for a specific record?

* In the current AngularJS embedded catalog, I find myself having to wait a long time for added content to load, when I'm not going to wind up using, say, Novelist as part of my cataloging process. Would there be a way to skip those added content calls in readonly mode? Especially since staff can't open those record details areas in readonly mode anyway. :-)

Both of those could be split off into separate bugs; they needn't hold this one up.

[Bill Erickson (berick)]

Thanks, Jane.

I have pushed commits to address #1 and #2.

For the remaining 2 comments, please open separate bugs for those. I'd also like to suggest we make changes to the Angular staff catalog proper to support whatever staff work flows are needed. Having the embedded TPAC be integral to any staff work flow, apart from simply seeing what displays, is a big step backwards.

[Jane Sandberg (sandbergja)]

Thank you, Bill and Garry. Pushed to master. Catalogers are going to be very happy about this!

[Jane Sandberg (sandbergja)]

I also threw in a brief release note.

Here are two bugs that I opened based on my comment #8:
* https://bugs.launchpad.net/evergreen/+bug/1850542
* https://bugs.launchpad.net/evergreen/+bug/1850546