User buckets do not respect barcode completion or opt-in settings

[Jeff Davis]

EG 3.3.4 (but all supported versions are likely affected)

Two issues when scanning barcodes on Circulation > User Buckets > Pending Users:

1. Barcode completion patterns are ignored. This is because EG does a direct pcrud search on actor.card instead of going through open-ils.actor.get_barcodes.

2. Opt-in settings are also ignored. Users who require opt-in in other contexts can be retrieved, added to a bucket, and modified via batch actions without being opted in.

To test barcode completion:
[1] Create an active barcode completion rule, e.g. prefix = 'PREFIX'.
[2] Create a user whose barcode that matches the rule, e.g. barcode = 'PREFIX1234'.
[3] In Circulation > User Buckets > Pending Users, enter the base barcode '1234' in the Scan Barcode input. This should retrieve user PREFIX1234, but it does not.

To test opt-in:
[1] In opensrf.xml, set the opt_in value to "true" and restart Evergreen.
[2] Set the org.patron_opt_boundary and/or org.restrict_opt_to_depth org unit settings.
[3] In Circulation > User Buckets > Pending Users, enter the barcode of a user who should require an opt-in and/or be blocked from opt-in based on your settings in step 2. Clicking on the barcode link in the grid will result in an opt-in prompt; however, you're still able to add the user to a bucket and then modify some account attributes (including profile, home library, active flag, and privilege expiration) via batch actions.

I'm reporting these issues together because a fix will touch the same code in both cases. We'll want to fix them both at the same time.

[Jennifer Pringle (jpringle-u)]

User buckets in 3.5 continue to ignore barcode completion and opt-in settings.

[Evergreen Bug Maintenance (bugmaster)]

Removing milestone targets because the bug does not have a branch and is not a release blocker.