Hide row selector checkboxes on queued record matches

Bug #1847652 reported by Jeff Davis
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.3
Undecided
Unassigned

Bug Description

EG 3.3+

In Angular Vandelay, when viewing record matches for a queued record, the grid row selector checkboxes are useless and misleading. They should be disabled.

To see what I mean, create a queue containing a record that matches multiple existing records. Inspect the queue and click on the link in the Matches column. This takes you to the Record Matches screen, which lists all the matching records for your queued record. On the left-hand side of the grid you'll see the usual row selector checkboxes, but they don't do anything; if you want to select a merge target (the only meaningful action that can be taken on this screen), you need to click on a cell in the Merge Target column. When the row selector checkboxes are visible, users will naturally assume that's what they should use to select a merge target, and will be confused when these checkboxes have no effect.

I'll share a fix for this momentarily.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp1847652-queued-record-matches-disable-row-selector removes the row selector checkboxes from the Record Matches grid:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1847652-queued-record-matches-disable-row-selector

Changed in evergreen:
milestone: none → 3.4.1
tags: added: angular cataloging vandelay
tags: added: pullrequest
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Test plan:

[1] In Angular Vandelay, create a queue containing a record that matches multiple existing records.
[2] Inspect the queue and click on the link in the Matches column, e.g. "(2)". This takes you to the Record Matches screen.
[3] Select a row using the grid row selector checkboxes and then click Return to Queue. Your selection has had no effect.
[4] Return to the Record Matches screen by clicking the Matches link again. This time, select a row by clicking a cell in the Merge Target column. Click Return to Queue. The link in the Matches column is now in bold and has an asterisk beside it, e.g. "(2)*", indicating that your merge target has been selected.
[5] Apply the fix, rebuild with `ng build`, and deploy your updates. Clear your browser cache to ensure you get the updates.
[6] Repeat step 2.
[7] Now, the grid has no row selector checkboxes. This makes it much more obvious that you need to use the Merge Target column to select your matching record.

Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Issue and fix confirmed. Merged to 3.3+. Thanks, Jeff!

Changed in evergreen:
status: New → Confirmed
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers