Angular Holdings Maint. Grid Fails to show All Items

[Bill Erickson]

Evergreen 3.4

The Holdings Maintenance grid in the Angular staff catalog only renders the first X rows of data if a grid configuration has been saved for the grid. Even though paging is disabled on the grid, the saved grid configuration may contain page size data, which clobbers the "show everything" value applied at load time.

The fix is to ignore any saved page size preference on grids whose paging has been disabled.

Patch en route.

[Bill Erickson (berick)]

Fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1845047-grid-no-paging-no-limit

[Elaine Hardy (ehardy)]

Do you have any suggestions for the best way to test this since it is on http://angular-acq-test.evergreencatalog.com/? Should I just check bib records with many items attached to see if all holds are displayed in Holdings view? did you observe a threshold number of items attached where over that number didn't display?

[Bill Erickson (berick)]

Hi Elaine, testing this one requires some hoop-jumping.

1. Find a grid with many rows that does not have the disablePaging attribute enabled in the code (i.e. paging controls are present in the UI).
2. Save grid settings, which will save the grid limit.
3. Add the disablePaging attribute to the grid in the code and rebuild.
4. Before applying the patch from this bug, you would only see 10 rows, even though paging is disabled, meaning all rows should appear. After applying this patch, all rows will appear.

[Elaine Hardy (ehardy)]

I am testing on http://angular-acq-test.evergreencatalog.com/ and this bug is listed on the feedback fest test list, I will have to assume that 1-3 have been done. Not something I know how to check!

I have been seeing more than 10 rows as I test other bugs on this test server. I will formally go back to confirm I am seeing more than 10 rows.

[Elaine Hardy (ehardy)]

Consistently seeing all items in Holdings view in http://angular-acq-test.evergreencatalog.com/

I have tested this code and consent to signing off on it with my name, Elaine Hardy and my email address, <email address hidden>

[Galen Charlton (gmc)]

Pushed to master, rel_3_5, and rel_3_4. Thanks, Bill and Elaine!

One way to reproduce the bug is to do the following:

[1] Save grid settings in the Holdings View tab in the _AngularJS_ staff catalog and set the row count to (say) 5.
[2] View a record with more than 5 items in the _Angular_ staff catalog. The Holdings View tab, which uses the same grid columns setting as the AngularJS version of the grid, won't show all of the items unless the patch is applied.