vandelay: record not appear selected after a merge target is selected

Bug #1843837 reported by tji@sitka.bclibraries.ca
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.6
Undecided
Unassigned

Bug Description

EG 3.3.3

On the old interface: after selecting a merge target, go back to Import queue, the record with the selected target appear to be selected.

On the new interface, it is no longer selected.

tags: added: cataloging vandelay
tags: added: angular
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Bill Erickson (berick)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Bill Erickson (berick) wrote :

Fix pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1843837-vand-merge-target-selected

From the commit:

After selecting an overlay target for a queued record in the MARC Import/Export Inspect Queue interface, the queued record row in question will be marked as selected upon returning to the Inspect Queue page. This is managed via a new grid @Input() attribute selectRowsOnLoad, which marks grid rows as selected as each row is rendered.

tags: added: pullrequest
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
milestone: none → 3.4.1
Revision history for this message
Bill Erickson (berick) wrote :

Removed PR to make a small fix...

tags: removed: pullrequest
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Alternate fix pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1843837-vand-persist-queue-selections

In addition to ensuring records with merge targets show as selected in the grid, this alternate version tracks import selection (with or without a merge target) across multiple renderings of the grid. With this, all selections are retained as users navigate to other interfaces (e.g. selecting merge targets) or apply grid filters, etc.

This is done by moving the grid row selection in-house so it's managed entirely by the vandelay service, similar to the Record Matches grid, instead of trying to synchronize selection criteria across vandelay and the grid.

tags: added: pullrequest
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
milestone: 3.4.1 → 3.4.2
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Revision history for this message
Bill Erickson (berick) wrote :

New branch pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1843837-vand-persist-queue-selections-1

Rebased to current master and includes a new commit to support Select All rows action. This was necessary to replace the functionality lost when disabling grid paging to support persistent grid import selection.

Changed in evergreen:
milestone: 3.4.3 → 3.5.0
Changed in evergreen:
milestone: 3.5.0 → 3.5.1
Changed in evergreen:
milestone: 3.5.1 → 3.5.2
Revision history for this message
Jennifer Weston (jweston) wrote :

Tested with Match Only Merge profile and 020 Record Match Set; loaded file to queue records at import.
Fix performs as expected. Selected target remains visibly selected when returning to the Inspect Queue page.

I have tested this code and consent to signing off on it with my name and my email address, Jennifer Weston, <email address hidden>

tags: added: signedoff
Revision history for this message
Beth Willis (willis-a) wrote :

If you choose a merge/overlay target for a record with multiple matches and then return to the queue, the record(s) displays as selected.  The records remain selected as the user navigates through multiple pages in vandelay interface.

But, if the user then checks the box to "Select All", any records that were selected become deselected.

Changed in evergreen:
milestone: 3.5.2 → 3.6.1
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Changed in evergreen:
milestone: 3.6.3 → 3.6.4
Changed in evergreen:
milestone: 3.6.4 → 3.7.2
Elaine Hardy (ehardy)
tags: added: cat-importexport
removed: cataloging vandelay
no longer affects: evergreen/3.3
no longer affects: evergreen/3.4
no longer affects: evergreen/3.5
Changed in evergreen:
milestone: 3.7.2 → 3.7.3
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers