outdated terminology remaining in the fm_idl.xml file

Bug #1843632 reported by Christine Burns
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.6
Undecided
Unassigned

Bug Description

Evergreen 3.3

I noticed new instances of the word "volume" in Server Admin. Jane Sandberg took a look and identified the issue.

There are several <class> and <field> elements with outdated terminology in their reporter:label attributes in the fm_idl.xml file.

For example, the reporter:label attribute on this line should be "Call Number", but it is "Call Number/Volume": https://github.com/evergreen-library-system/Evergreen/blob/master/Open-ILS/examples/fm_IDL.xml#L3095

New references to outdated terminology "Volume" in Evergreen 3.3

Admin -> Server Admin -> Call Number Prefixes

The page header is "Call Number/Volume Prefix Configuration" & the button = New Call Number/Volume Prefix

Admin -> Server Admin -> Call Number Suffixes

The page header is "Call Number/Volume Suffix Configuration"

Button = New Call Number/Volume Suffix

All label attributes including "Volume" should be updated so Volume is removed.

tags: added: bitesize terminology
Revision history for this message
Galen Charlton (gmc) wrote :

More: various instances of "copy location" should now be "shelving location"

Revision history for this message
Shula Link (slink-g) wrote :

To clarify - would the related permissions to copy location also need to be updated to shelving location for consistence, e.g. UPDATE_COPY_LOCATION?

Revision history for this message
Jane Sandberg (sandbej) wrote :

I think it's safest to leave the permissions as is. Changing their names would also require changes to the code, database migrations, and some careful testing to make sure nobody loses access to things they need.

Revision history for this message
Galen Charlton (gmc) wrote :

Agreed, the permission codes should be left as is, but it would be fine to update their stock descriptions.

Revision history for this message
Shula Link (slink-g) wrote :

I *think* this got all the labels for both, and the associated translation files:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=1561196389b5accbf489c0ca92f51b06085baf2b

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.6.1
tags: added: cleanup
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Changed in evergreen:
milestone: 3.6.3 → 3.6.4
Changed in evergreen:
milestone: 3.6.4 → 3.7.2
Revision history for this message
Jason Boyer (jboyer) wrote :

Hi Shula, I have some feedback about your changes.

First, the initial issue is caused in part by the IDL file in Open-ILS/examples/fm_IDL.xml that doesn't appear to be addressed by your patch, so that will need to be looked at. There are several reporter:label fields still set to Copy Location.

Even though changing comments won't generally be visible to end users changing them is a good idea to keep devs from accidentally re-introducing old terminology.

All of the past upgrade scripts and the translations can (and should) be ignored. Any non-comment changes made to the files in Open-ILS/src/sql/Pg/ would also be performed in a new file you write and put in the upgrade directory. (It looks like that's just the stuff in 950.data.seed-values.sql currently.) The reason for this is that old upgrade scripts are treated as if they're encased in stone; if you want to make new changes you just need to add a new upgrade script to the list. There have been a couple times that this convention has been broken but that's usually to prevent unexpected data loss or crashes discovered after an upgrade.

Translations can be ignored because they'll be rebuilt automatically from your changes to other files.

tags: added: needsrepatch
removed: pullrequest
tags: added: needswork
removed: needsrepatch
Changed in evergreen:
milestone: 3.7.2 → 3.7.3
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers