Browser client MARC flat text editor control fields missing backslashes

Bug #1841823 reported by Bill Erickson
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.2
Undecided
Unassigned
3.3
Undecided
Unassigned

Bug Description

* Evergreen 3.3
* AngularJS and Angular clients affected.

In the XUL client, 006, 007, and 008 fields in the flat text editor are presented with backslash "\" characters in place of each empty value so users can more easily see which slot each value fills.

In the browser client, only the first empty field for a given control fields is replaced with a backslash and the remainders are empty strings.

XUL example:

=008 970701s1988\nyu\00\eng\

Browser example:

=008 970701s1988\nyu 00 eng

Beware the solution may require editing two files:

Open-ILS/web/js/ui/default/staff/marcrecord.js
Open-ILS/src/eg2/src/assets/js/marcrecord.js

Revision history for this message
Meg Stroup (mstroup) wrote :

Can confirm the absence of "\" characters in 3.1.13.

Examples like:

=008 160331p20162015cau136\ vleng d
and
=008 180716s2018\ nyua b 000 0aeng c

help illustrate that the presence of a "\" makes it easier for catalogers to see what value belongs where: it's easier to count off backslashes than empty fields.

Changed in evergreen:
status: New → Confirmed
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Fixes pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1841823-marc-flat-edit-slashes

There are 2 commmits. When backporting to 3.2 and 3.3, only the tip commit is needed.

Changed in evergreen:
milestone: none → 3.4-beta2
assignee: Bill Erickson (berick) → nobody
tags: added: pullrequest
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta2 → 3.4.1
Changed in evergreen:
milestone: 3.4.1 → 3.4.2
Bill Erickson (berick)
tags: added: staffcatalog
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Revision history for this message
Elaine Hardy (ehardy) wrote :

Tested in https://tiffany-master.gapines.org/eg/staff/

\ was present for space in 006, 007 and 008 fields.

Revision history for this message
Elaine Hardy (ehardy) wrote :

I have tested this code and consent to signing off on it with my name, Elaine Hardy and by email: <email address hidden>

Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Thanks Elaine. AngJS fix merged to 3.3, AngJS and Ang fixes merged to 3.4 and master.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers