Angular catalog holdings view suffers from material icon formatting issue

Bug #1840982 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.3
Fix Released
Medium
Unassigned

Bug Description

Evergreen 3.3

Part of the work of bug #1830912 was identifying material icons that behave oddly when served locally instead of from the Google servers -- a handful of icons add extra padding. Most of them were replaced, but I just found another that affects the Angular catalog Holdings view.

When copy rows are expanded, barcode values and sometimes call number values fail to render under the "Location/Barcode" column. Closer inspection shows the data is there, it's just pushed outside the scope of the grid cell because of the extra icon padding.

Replacing "arrow_right" with keyboard_arrow_right (and arrow_drop_down with keyboard_arrow_down for consistency) fixes the issue.

Branch en route.

Revision history for this message
Bill Erickson (berick) wrote :

Fix pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1840982-holdings-icon-fix

To test, apply patch and confirm the "Location/Barcode" column in the Holdings grid contains values for every row, copy barcodes in particular.

Changed in evergreen:
milestone: 3.3.3 → 3.3.4
tags: added: pullrequest
Changed in evergreen:
milestone: 3.3.4 → 3.3.5
Changed in evergreen:
milestone: 3.3.5 → 3.4.2
Bill Erickson (berick)
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Bill Erickson (berick)
tags: added: staffcatalog
tags: removed: catalog
Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
assignee: Jane Sandberg (sandbej) → nobody
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks for this fix, Bill. The holdings view was looking very odd without it. It works well. I've pushed it to master, rel_3_4, and rel_3_3.

tags: added: signedoff
Changed in evergreen:
status: New → Fix Committed
importance: Undecided → Medium
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.