Web Client: Search Type included in search box and multiplies when sorting

Bug #1839684 reported by Jennifer Pringle
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.2
Undecided
Unassigned
3.3
Undecided
Unassigned

Bug Description

Evergreen 3.3

When doing a search from the Basic or Advanced search in either the OPAC or the client the search Type (Title, Journal Title, Author, Subject, Series) is added to the search bar. The only type this doesn't happen with is Keyword. (In 3.1 the type is included in the searches from the advanced screen but not from the basic search.)

If you sort your results the search type is added again every time you sort. (This doesn't happen in 3.1)

Revision history for this message
Jennifer Pringle (jpringle-u) wrote :
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp1839684-repeating-qtype has a simple but arguably partial fix: don't prepend the qtype to the query if the query already begins with the qtype.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1839684-repeating-qtype

This prevents duplicate prefixes, but a basic author search still shows as "author:mozart" in the searchbox. I wasn't immediately able to strip the query type from the search string for some reason, and there may be a case for keeping it (but not for duplicating it, of course).

Changed in evergreen:
status: New → Confirmed
tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.4-beta2
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta2 → 3.4.1
Changed in evergreen:
milestone: 3.4.1 → 3.4.2
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Revision history for this message
Gina Monti (gmonti90) wrote :

I have tested the potential fix; it does prevent prefixes from duplicating when results are sorted. I sign off on this with my name Gina Monti. Email: <email address hidden>

tags: added: signedoff
Revision history for this message
Mike Rylander (mrylander) wrote :

Thanks, Jeff and Gina! Picked to master, 3.4 and 3.3.

Changed in evergreen:
assignee: nobody → Mike Rylander (mrylander)
assignee: Mike Rylander (mrylander) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments