Login page missing a h1 heading

[Tiffany Little]

The login page has text that resembles a heading but is not marked as such. The "Sign In" text should be wrapped in <h1> tags. This will help with screen reader and keyboard-only navigation.

<legend>Sign In</legend>

See: https://www.w3.org/WAI/WCAG21/quickref/?showtechniques=331#headings-and-labels

See also: https://wiki.evergreen-ils.org/doku.php?id=accessibility:webclient_audit

[Eva Cerninakova (ece)]

Open-ILS/src/templates/staff/t_login.tt2:6

[Shula Link (slink-g)]

Fix pushed to:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/slink/lp1839365_login_page_missing_h1_header

[Terran McCanna (tmccanna)]

Hi Sam,

The commit you pushed includes deletes to two files that don't look like they should be included. Can you please rebase?

[Shula Link (slink-g)]

Rebased and pushed back up. Hopefully I did that right.

[Shula Link (slink-g)]

Okay, now it's definitely rebased and pushed back up without the mystery deleted files.

[Terran McCanna (tmccanna)]

Thanks, Sam!

Normally h1 and legend wouldn't be nested like this, but since it's arguably both a page title and a form title, and it doesn't appear to break anything to have them nested, I'm okay with it. If anyone else would rather avoid that and just use one, I would opt for the h1 only as it's more appropriate for accessibility needs.

My sign-off patch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1839365_login_page_missing_h1_header_signoff

[Galen Charlton (gmc)]

Pushed to master, rel_3_5, and rel_3_4. Thanks, Shula and Terran!

Per https://stackoverflow.com/questions/45362950/header-or-legend, the fieldset could probably be taken out entirely, along with the legend tag, but that can be the subject of another patch.