Comment 3 for bug 1839341

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks for taking this on, Kyle! Overall, I really like it.

A few thoughts:

* The filter <input> needs an accessible label. The best options would be to add a visible label (e.g. <label>Filter<input></label>) or to add an aria-label attribute.
* For power users, it would be helpful to have a "name" column that is hidden by default, but could be enabled.
* The previous version of this screen allowed descriptions to include links, but these are not displaying properly in the Angular version (look at lib.timezone, for example)
* When I add a value, the grid update properly. When I then delete that value, the context column clears properly, but the Value remains.

And... these need not hold up this ticket, but would be good follow-up work:
* The description for "Default Classification Scheme" asks users to enter numbers, but your interface is kind enough to give users a combobox so users don't even need to know the scheme's ID. We should update the description accordingly (and look for similar descriptions).
* It would be great to have a validator to make sure that interval values are entered in the correct format.