Angular FmRecordEditorComponent needs an "inline" mode

Bug #1837260 reported by Bill Erickson
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

Evergreen 3.3

The Angular FmRecordEditorComponent currently operates within a modal dialog window. However, there are times where it's preferable to display the editor inline in the page instead of requiring the user to first open the dialog. Having the ability to embed the editor pane directly in the page will make the component more generally useful as a page-building widget.

I propose we add:

@Input() displayMode: 'dialog' | 'inline' = 'dialog';

When displayMode is 'inline', the editor pane is rendered on the spot.

Branch en route.

Revision history for this message
Bill Erickson (berick) wrote :

Mostly done here, w/ sandbox example, but I still need to provide some indication when a save operation has completed (toast, etc.) since we no longer have the closing of the dialog as an indicator.;a=shortlog;h=refs/heads/user/berick/lp1837260-fm-editor-inline

Changed in evergreen:
status: New → In Progress
milestone: none → 3.4-beta1
Revision history for this message
Bill Erickson (berick) wrote :

Updated branch pushed. Includes a second commit to add oils_obj:required fields to config.billing_type so the sandbox example will behave as expected.

From the commit:

Adds support for a new @Input() attribute called "displayMode", which defaults to "dialog". When the value is set to "inline", the editor pane will be rendered inline within the page where the <eg-fm-record-editor/> element resides.

Adds support for success/fail toasts.

Implements the handlers for the previously defined onSave$, onError$, and onCancel$ EventEmitters, primarily so callers can interact with the editor in "inline" mode where no "close()" operation occurs.

Sandbox example included.


tags: added: pullrequest
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
status: In Progress → New
Kyle Huckins (khuckins)
Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
Revision history for this message
Kyle Huckins (khuckins) wrote :

This feels like a useful addition, and it works without a hitch. Thanks Bill!

I have tested this code and consent to signing off on it with my name, Kyle Huckins, and my email address, <email address hidden>.

Changed in evergreen:
assignee: Kyle Huckins (khuckins) → nobody
tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master. Thanks, Bill and Kyle!

Changed in evergreen:
status: New → Fix Committed
importance: Undecided → Wishlist
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers