Kpac: replace custom javascript with placeholder attribute

[Jane Sandberg]

The Kpac has two files with the following javascript:

onfocus="if(this.value=='[% seed %]'){this.value='';this.style.color='#424242';}"
onblur="if(this.value==''){this.value='[% seed %]'; this.style.color='#aaa';}"

This javascript basically just does what the HTML5 placeholder attribute does. Since the placeholder attribute is widely supported (and used a lot throughout Evergreen), I think it is quite safe to simplify these files by replacing the onfocus/onblur js with a placeholder attribute.

The two files are:
* https://github.com/evergreen-library-system/Evergreen/blob/master/Open-ILS/src/templates/kpac/parts/searchbox.tt2
* https://github.com/evergreen-library-system/Evergreen/blob/master/Open-ILS/src/templates/kpac/getit.tt2

This would be a great first project for somebody new to Evergreen development.

[Jane Sandberg (sandbergja)]

P.S. this is in Evergreen 3.1.2. :-)

[Shula Link (slink-g)]

Is this still a needed fix?

[Galen Charlton (gmc)]

Yep, this is still an issue.

[Shula Link (slink-g)]

Confirmed, fix pushed to:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=adb68006876d6dfa3906e3e98f457f525c82d65b

[Terran McCanna (tmccanna)]

I have tested this and it looks good to me. My sign off is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1834258_replace_javascript_with_placeholder_attribute_signoff

[Chris Sharp (chrissharp123)]

Pushed to master. Thanks, Shula and Terran!

[Chris Sharp (chrissharp123)]

Also pushed to rel_3_6 and rel_3_7