eg-bool is relentlessly positive

Bug #1833080 reported by Galen Charlton on 2019-06-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

The Angular eg-bool component currently expects a true boolean value to be passed to it. However, there are cases where it can be passed the strings 't' or 'f', particularly when processing IDL objects where boolean columns use those strings. As a consequence, an IDL boolean field whose value is 'f' still displays a "Yes" when it should display "No".

Evergreen 3.3+

Galen Charlton (gmc) on 2019-06-17
Changed in evergreen:
importance: Undecided → Medium
Galen Charlton (gmc) wrote :
tags: added: pullrequest
Galen Charlton (gmc) wrote :

I note that an alternative approach would be to ensure that the Angular app always converts between 't'/'f' and true boolean values when handing IDL objects. I think that's a good idea in the long run, but suspect it would take rather more effort.

Bill Erickson (berick) on 2019-06-20
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
status: New → Confirmed
Bill Erickson (berick) wrote :

Issue and fix confirmed. Tests pass. Bonus points for component test spec, yay. Merged to 3.3 and up.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers