Update to Angular version 8

[Bill Erickson]

Evergreen circa 3.3

Angular version 8 is now available:

https://blog.angular.io/version-8-of-angular-smaller-bundles-cli-apis-and-alignment-with-the-ecosystem-af0261112a27

[Bill Erickson (berick)]

Note to self:

https://update.angular.io/#7.2:8.0

Going to pause this and give project dependencies (e.g. ng-bootstrap) some time to catch up.

[Bill Erickson (berick)]

ng-bootstrap now officially supports Angular 8. I have pushed a working branch that migrates current master from Angular 7 to Angular 8. It's a messy branch at the moment and needs a lot more testing, but wanted to get it posted:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1830973-angular-8-wip

Note it requires update Node (see changes in Makefile.install) and a 'rm -rf node_modules' and 'npm install'

Angular dev/prod, Angular tests and ng-lint all pass. Similarly AngularJS building does not appear to be negatively impacted by the NodeJS update.

Will test more and clean up branch soon.

[Bill Erickson (berick)]

Beware any Angular branches merged after this branch will require updates to be Angular8-compatible. There's a migration routine built in to automate the process (though in some cases it may require manual intervention).

The command:

ng update @angular/core --from 7 --to 8 --migrate-only

And when we do decide to flip the switch, I can redo the migration on current master.

[Bill Erickson (berick)]

Updated branch pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1830973-angular-v8-update

To test, first update dependencies:

$ wget -N https://nodejs.org/dist/v12.13.0/node-v12.13.0-linux-x64.tar.xz

$ sudo tar -C /usr/local --strip-components 1 -xJf node-v12.13.0-linux-x64.tar.xz

$ sudo npm install -g @angular/cli@^8.2.0

$ cd $EVERGREEN/Open-ILS/src/eg/ ; npm install

[Galen Charlton (gmc)]

Looks good to me and spot-checking in the UI works. Signoff branch is working/user/gmcharlt/lp1830973_signoff

[Chris Sharp (chrissharp123)]

This has been pushed to master. Thanks, Bill and Galen!