pin version of angular/cli that is installed globally by Makefile.common

Bug #1830972 reported by Galen Charlton on 2019-05-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
High
Unassigned
3.2
High
Unassigned

Bug Description

Angular 8.0 was released recently and requires newer versions of node and npm than what Evergreen currently uses. At present, angular/cli is installed globally as part of the install_developer Makefile.install option, which means that recent full builds of the Angular staff client started failing with errors like this:

Running ng build --prod:
You are running version v8.11.4 of Node.js, which is not supported by Angular CLI 8.0+.
The official Node.js version that is supported is 10.9 or greater.

Please visit https://nodejs.org/en/ to find instructions on how to update Node.js.
Return Value = 3

(see http://testing.evergreen-ils.org/~live/archive/2019-05/2019-05-29_16:00:03/test.29.html)

To avoid this, we need to pin the version of angular/cli that gets installed globally.

Galen Charlton (gmc) on 2019-05-29
Changed in evergreen:
importance: Undecided → High
milestone: none → 3.3.2
tags: added: angular
Galen Charlton (gmc) wrote :

A two patch series, including one written by Ben Shum, is available in

working/user/gmcharlt/lp1830972_pin_global_angular_cli
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1830972_pin_global_angular_cli

Note that using "//" as a key to add a comment is allowed per https://stackoverflow.com/a/14221781

tags: added: installation pullrequest
Bill Erickson (berick) on 2019-05-29
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Bill Erickson (berick) wrote :

Thanks, Galen.

Patch tested and confirmed.

make -f Makefile.install ubuntu-xenial-developer installed ng-cli version 7.3.9 as expected.

Fix merged to 3.2 and above.

Changed in evergreen:
status: New → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers