CSS colors needs to be broken out more for customizing

Bug #1830960 reported by Rogan Hamby
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

One challenge for those doing frequent migrations with Evergreen is that it makes a lot of assumptions in terms of the relative colors defined in colors.tt2. However, libraries often have color schemes that don't work requiring a number of changes to the style.css.tt2 and new colors added in the colors.tt2. The patch here provides new colors in the colors.tt2 so that relatively easy customization can be done via the colors without having to change the CSS file. This will also make upgrades easier long term for libraries with customized OPACs if they don't have to touch the style.css.tt2 as much. I've been using these for a long time to make customizations easier.

It includes:

- changes the staff-hold element by default to the background, this isn't quite as pretty as the light accent but prevents a common issue of unreadable text (worth the trade)
- separate footer background text colors
- add a button color for backgrounds in addition to the button text color
- add a header text color
- add a distinct background, text and text hover color for the header links bar
- add background, over and over text for the opac button

user/rogan/more_colors_for_opac_customizations

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=bab2933f44581ff7231204b65b19dc66b7c191f4

tags: added: css
Galen Charlton (gmc)
Changed in evergreen:
milestone: none → 3.4-beta1
Revision history for this message
Rogan Hamby (rogan-hamby) wrote :

I'll be adding a commit to this to add release notes including documentation of what to look for when updating the colors.tt2 file.

tags: added: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Changes seems pretty straightforward, not sure if Rogan still has more commit to add for this as indicated.

Revision history for this message
Rogan Hamby (rogan-hamby) wrote : Re: [Bug 1830960] Re: CSS colors needs to be broken out more for customizing

I need to add some docs for release notes but will do that later today.

On Mon, Jul 29, 2019 at 8:45 AM Ben Shum <email address hidden> wrote:

> Changes seems pretty straightforward, not sure if Rogan still has more
> commit to add for this as indicated.
>
> --
> You received this bug notification because you are a member of Evergreen
> Bug Wranglers, which is subscribed to Evergreen.
> https://bugs.launchpad.net/bugs/1830960
>
> Title:
> CSS colors needs to be broken out more for customizing
>
> Status in Evergreen:
> New
>
> Bug description:
> One challenge for those doing frequent migrations with Evergreen is
> that it makes a lot of assumptions in terms of the relative colors
> defined in colors.tt2. However, libraries often have color schemes
> that don't work requiring a number of changes to the style.css.tt2 and
> new colors added in the colors.tt2. The patch here provides new
> colors in the colors.tt2 so that relatively easy customization can be
> done via the colors without having to change the CSS file. This will
> also make upgrades easier long term for libraries with customized
> OPACs if they don't have to touch the style.css.tt2 as much. I've
> been using these for a long time to make customizations easier.
>
> It includes:
>
> - changes the staff-hold element by default to the background, this
> isn't quite as pretty as the light accent but prevents a common issue of
> unreadable text (worth the trade)
> - separate footer background text colors
> - add a button color for backgrounds in addition to the button text color
> - add a header text color
> - add a distinct background, text and text hover color for the header
> links bar
> - add background, over and over text for the opac button
>
>
> user/rogan/more_colors_for_opac_customizations
>
> https://git.evergreen-
>
> ils.org/?p=working/Evergreen.git;a=commit;h=bab2933f44581ff7231204b65b19dc66b7c191f4
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1830960/+subscriptions
>

Revision history for this message
Rogan Hamby (rogan-hamby) wrote :

Update

user/rogan/more_colors_for_opac_customizations
bab2933f44581ff7231204b65b19dc66b7c191f4
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=bab2933f44581ff7231204b65b19dc66b7c191f4

+

user/rogan/lp1830960_w_docs
53f4bd0ae805c1295814e8f5c5c5dee1386103d9
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=53f4bd0ae805c1295814e8f5c5c5dee1386103d9

which fixes two small issues I found while working on docs plus the docs themselves.

Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta1 → 3.next
Revision history for this message
Terran McCanna (tmccanna) wrote :

This is very handy. There are some instances where things don't necessarily apply the way you think they will because of the way the divs are set up (for example, if you change the footer here, it only changes the display for the part of the footer below the footer text, but I consider that an issue with the HTML of the footer, not an issue with this CSS).

I've combined both of Rogan's commits above and signed off here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1830960_css_for_opac_customizations_signoff

tags: added: signedoff
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: 3.next → 3.7-beta
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master for inclusion in 3.7 as one of the likely last gaps of TPAC. Thanks, Rogan and Terran!

Changed in evergreen:
status: New → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.