MARC import lacks ability to view and edit incoming MARC record

[Remington Steed]

Affected versions: Evergreen 3.3+

This was reported by our cataloging librarian.

The new Angular version of the MARC Import screen is missing a feature from the XUL client that allowed you to both view and edit the incoming MARC record while inspecting an imported queue. This was helpful for records that failed to import, because you could quickly check the MARC and make corrections to improve matching, then import those records again. In the XUL client, there was a "View MARC" link in every row in the table of attempted imported items.

[Galen Charlton (gmc)]

The Angular MarcEditorComponent is available in 3.3 and later, so wiring it up to Angular Vandelay should be doable.

[Meg Stroup (mstroup)]

Confirming for SCLENDS on 3.3.3.

Created a non-imported record (original cataloging). I was able to create the record but not edit it.

[Bill Erickson (berick)]

Work started here to integrate the Angular MARC editor for queued bib editing. Still some work left to do:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1830923-vand-edit-queued-bib

[Bill Erickson (berick)]

Master and 3.3-era branches pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1830923-vand-edit-queued-bib

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1830923-vand-edit-queued-bib-3.3

I confirmed the 3.3 branch compiles, but did not test it on a 3.3 server.

==

Note these branches use the Angular MARC editor, which currently only support flat-text editing. Since there is no entry point to editing a Vandelay queued bib record in the AngJS app, the link to jump into the rich MARC editor is hidden. We need to decide if this will suffice for now.

[Remington Steed (rjs7)]

Bill, I tested your master-era branch, but "ng build --prod" produced this error (apparently related to the Angular 8 update from bug #1830973):

ERROR in app/staff/cat/vandelay/queued-record.component.ts:20:6 - error TS2554: Expected 2 arguments, but got 1.

20 @ViewChild('updateSuccess') updateSuccess: StringComponent;

[Bill Erickson (berick)]

Sounds about right. Thanks, Remington. Fixing now.

[Bill Erickson (berick)]

I rebased and force-pushed the non-3.3 branch to master:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1830923-vand-edit-queued-bib

Fortunately, the rebase alone solved it, so we should not need separate branches for 3.4 and 3.5. No changes to the commits in question were required.

[Remington Steed (rjs7)]

Tested and it works! Here's my signoff branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1830923-vand-edit-queued-bib

[Galen Charlton (gmc)]

Works for me, although I've added a couple follow-ups that I would like somebody else to at least eyeball before pushing. Branch for master/3.4 is

user/gmcharlt/lp1830923_signoff_and_followup

Branch for 3.3 is

user/gmcharlt/lp1830923_signoff_and_followup-3.3

[Bill Erickson (berick)]

2 new branches pushed:

user/berick/lp1830923_signoff_and_followup-take2

* Signoffs plus another commit to replace some tabs.

---

user/berick/lp1830923_signoff_and_followup-3.3-take2

* Signoffs
* Any reason the inPlaceMode hiding commit was not backported to the 3.3 branch?

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=14693bb8a2a110c22c712ac83ceaec03746944d5

[Galen Charlton (gmc)]

Pushed to master, rel_3_4, and rel_3_3. Thanks, Bill and Remington!

I had originally not ported the inPlaceMode hiding commit because I misread what hideFullEditorLink in your 3.3 branch was doing. Upon seeing the light and testing it in a 3.3 system, I've included the inPlaceMode hiding commit in my push to rel_3_3.