holdings editor can spew MultiMap errors in browser log

Bug #1830394 reported by Galen Charlton
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.2
Fix Released
Undecided
Unassigned

Bug Description

Due to a mistake in how $scope.working gets cleared, various operations in the holdings editor can spawn a bunch of errors in the browser console like this:

TypeError: "$scope.working.MultiMap[keys[i]] is undefined"
    hasMulti https://dev-galen2.equinoxinitiative.org/js/ui/default/staff/cat/volcopy/app.js:1203
    ...

If nothing else, this is distracting when attempting to debug other issues.

Evergreen 3.3+

Revision history for this message
Galen Charlton (gmc) wrote :
Changed in evergreen:
milestone: none → 3.3.2
tags: added: pullrequest
Revision history for this message
Kyle Huckins (khuckins) wrote :

Does what it says on the tin, my volcopy editor console is so much cleaner now.

I have tested this code and consent to signing off on it with my name, Kyle Huckins and my email address, <email address hidden>.

Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
tags: added: signedoff
Changed in evergreen:
assignee: Kyle Huckins (khuckins) → nobody
Revision history for this message
Bill Erickson (berick) wrote :

Issue and fix confirmed. Merged to 3.2 and above. Thanks Galen, Kyle.

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
status: New → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
milestone: 3.3.2 → 3.3.3
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.