Protect more modals from accidental closures, the angular version

Bug #1827942 reported by Andrea Neiman on 2019-05-06
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
3.3
Medium
Unassigned

Bug Description

Clicking outside an Angular modal will dismiss the modal, resulting in potentially lost work.

Bug 1689325 fixed this for AngularJS modals so I am requesting that this be fixed for Angular modals as well.

Zavier (zavierbanks) on 2019-09-16
Changed in evergreen:
assignee: nobody → Zavier (zavierbanks)
Zavier (zavierbanks) on 2019-09-17
Changed in evergreen:
status: New → Fix Committed
Revision history for this message
Remington Steed (rjs7) wrote :

Zavier, have you worked on a solution for this bug? If so, could you post a comment here that explains what you've done or where you could share the code? We use the status "Fix Committed" to mean "code has been shared and reviewed, and has been accepted into Evergreen", and that process usually happens in comments on the bug ticket. Since that hasn't happened here yet, I'll set the status back to "New" for now.

Of course, if you've confirmed that this bug exists in Evergreen, feel free to change the status to "Confirmed".

Changed in evergreen:
status: Fix Committed → New
Revision history for this message
Zavier (zavierbanks) wrote :

My mistake.

I pushed up a branch here. I made use of the backdrop parameter for the dialog object.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/zbanks/lp1827942_angular_protect_modal_closures

tags: added: pullrequest
Changed in evergreen:
status: New → Invalid
status: Invalid → New
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Thanks, Zavier!

I have confirmed the bug on EG 3.3. I've also set the importance to Wishlist, same as the previous AngularJS bug, and targeted it to the next release. But there's a case to be made that this is really a bugfix rather than a feature request, in which case the priority should be changed and this should be targeted to 3.4.

Changed in evergreen:
milestone: none → 3.next
Revision history for this message
Jane Sandberg (sandbej) wrote :

Thanks, Zavier! It works well for me. Signoff branch at user/sandbergja/lp1827942_angular_protect_modal_closures_signoff

tags: added: signedoff
Changed in evergreen:
assignee: Zavier (zavierbanks) → nobody
Revision history for this message
Jane Sandberg (sandbej) wrote :

And I agree, Jeff. This makes sense as a bugfix.

Changed in evergreen:
milestone: 3.next → 3.4.2
importance: Wishlist → Medium
Galen Charlton (gmc) on 2019-12-27
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_4, and rel_3_3. Thanks, Zavier and Jane!

Zavier, I believe this is your first patch accepted into Evergreen. Congratulations!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Revision history for this message
Galen Charlton (gmc) wrote :

I also pushed a follow-up that fixes lint warnings as well as an issue that prevented progress dialogs from appearing.

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers