Protect more modals from accidental closures, the angular version

[Andrea Neiman]

Clicking outside an Angular modal will dismiss the modal, resulting in potentially lost work.

Bug 1689325 fixed this for AngularJS modals so I am requesting that this be fixed for Angular modals as well.

[Remington Steed (rjs7)]

Zavier, have you worked on a solution for this bug? If so, could you post a comment here that explains what you've done or where you could share the code? We use the status "Fix Committed" to mean "code has been shared and reviewed, and has been accepted into Evergreen", and that process usually happens in comments on the bug ticket. Since that hasn't happened here yet, I'll set the status back to "New" for now.

Of course, if you've confirmed that this bug exists in Evergreen, feel free to change the status to "Confirmed".

[Zavier (zavierbanks)]

My mistake.

I pushed up a branch here. I made use of the backdrop parameter for the dialog object.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/zbanks/lp1827942_angular_protect_modal_closures

[Jeff Davis (jdavis-sitka)]

Thanks, Zavier!

I have confirmed the bug on EG 3.3. I've also set the importance to Wishlist, same as the previous AngularJS bug, and targeted it to the next release. But there's a case to be made that this is really a bugfix rather than a feature request, in which case the priority should be changed and this should be targeted to 3.4.

[Jane Sandberg (sandbergja)]

Thanks, Zavier! It works well for me. Signoff branch at user/sandbergja/lp1827942_angular_protect_modal_closures_signoff

[Jane Sandberg (sandbergja)]

And I agree, Jeff. This makes sense as a bugfix.

[Galen Charlton (gmc)]

Pushed to master, rel_3_4, and rel_3_3. Thanks, Zavier and Jane!

Zavier, I believe this is your first patch accepted into Evergreen. Congratulations!

[Galen Charlton (gmc)]

I also pushed a follow-up that fixes lint warnings as well as an issue that prevented progress dialogs from appearing.