Misspelling in edit description "Items Out Lost display setting"

[Lugene Shelly]

Text in the description for editing the Library Setting for Items Out Lost Display setting reads "Value is a numeric code, describing which list the circulation should appear while checked out and whether the circulation should continue to appear in the bottom list, when checked in with oustanding fines."
The s and t in "outstanding" are transposed.
v3.1.11

[Shula Link (slink-g)]

Fix pushed here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/slink/lp1826759_misspelling_in_edit_description

[Jennifer Bruch (jbruchpails)]

Tried testing this today on Emerald Test Server. Was able to login to the staff interface but when trying access the Server Admin and Local Admin pages from the menu bar I got a 404 error.

[Shula Link (slink-g)]

I'm getting the same error when I went to check. I don't *think* it's related to this patch?

[Jason Boyer (jboyer)]

I agree that this patch shouldn't have any effect on that 404 error on the test server, but I do want to give some feedback about the current patch. It's unlikely to be accepted in its current form given that it changes a lot of unnecessary files. To fix this should only require an update to 950.data.seed-values.sql and a new patch file in OpenILS/src/sql/Pg/upgrade (named something like XXXX.data.lp1826759_items_out_typo.sql or similar). This way new databases will have the fix from the start and once existing databases run the new XXXX.data... file they'll also be corrected.

We don't edit previously released upgrade scripts except in highly unusual circumstances (like bug 1858448) and the .po files will be regenerated from the updated 950 seed data file during the next round of translation updates.

The upgrade file doesn't need to be any more than a BEGIN;, some updates to correct the existing entries, and a COMMIT;.

[Shula Link (slink-g)]

Got it, I'll fix such.

[Shula Link (slink-g)]

New patch pushed to :

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=3cd3586a08a2aa49b367f6112d1920aac629a391

[Jennifer Bruch (jbruchpails)]

Reviewed the setting today and the spelling issue appears to be fixed.

I have tested and sign off on this fix.

Jennifer Bruch at PaILS/SPARK

[Terran McCanna (tmccanna)]

This was signed off back in March but it missed getting the signedoff tag.

[Jason Stephenson (jstephenson)]

Thanks, Shula! I have pushed the typo fix to master, rel_3_7, and rel_3_6.

I made a few modifications to the commit message and the database upgrade script so that they are easier to read and follow Evergreen community standards.