Misspelling in edit description "Items Out Lost display setting"

Bug #1826759 reported by Lugene Shelly on 2019-04-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned

Bug Description

Text in the description for editing the Library Setting for Items Out Lost Display setting reads "Value is a numeric code, describing which list the circulation should appear while checked out and whether the circulation should continue to appear in the bottom list, when checked in with oustanding fines."
The s and t in "outstanding" are transposed.
v3.1.11

Jane Sandberg (sandbej) on 2019-04-29
tags: added: bitesize
Revision history for this message
Shula Link (slink-g) wrote :
tags: added: pullrequest
Shula Link (slink-g) on 2021-02-03
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Jennifer Bruch (jbruchpails) wrote :

Tried testing this today on Emerald Test Server. Was able to login to the staff interface but when trying access the Server Admin and Local Admin pages from the menu bar I got a 404 error.

Revision history for this message
Shula Link (slink-g) wrote :

I'm getting the same error when I went to check. I don't *think* it's related to this patch?

Revision history for this message
Jason Boyer (jboyer) wrote :

I agree that this patch shouldn't have any effect on that 404 error on the test server, but I do want to give some feedback about the current patch. It's unlikely to be accepted in its current form given that it changes a lot of unnecessary files. To fix this should only require an update to 950.data.seed-values.sql and a new patch file in OpenILS/src/sql/Pg/upgrade (named something like XXXX.data.lp1826759_items_out_typo.sql or similar). This way new databases will have the fix from the start and once existing databases run the new XXXX.data... file they'll also be corrected.

We don't edit previously released upgrade scripts except in highly unusual circumstances (like bug 1858448) and the .po files will be regenerated from the updated 950 seed data file during the next round of translation updates.

The upgrade file doesn't need to be any more than a BEGIN;, some updates to correct the existing entries, and a COMMIT;.

Revision history for this message
Shula Link (slink-g) wrote :

Got it, I'll fix such.

Revision history for this message
Shula Link (slink-g) wrote :
Revision history for this message
Jennifer Bruch (jbruchpails) wrote :

Reviewed the setting today and the spelling issue appears to be fixed.

I have tested and sign off on this fix.

Jennifer Bruch at PaILS/SPARK

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments