continue past alert and confirm dialogs with keyboard space or enter

Bug #1826584 reported by a. bellenir on 2019-04-26
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.2
Undecided
Unassigned
3.3
Undecided
Unassigned
3.4
Undecided
Unassigned
3.5
Undecided
Unassigned

Bug Description

it would be convenient if a user could proceed past an alert or confirm dialog by pressing 'enter' or 'space' on the keyboard.

(the 'escape' key can already be used to dismiss dialogs)

Revision history for this message
a. bellenir (abellenir) wrote :

here's a simple patch just adds the "autofocus" attribute the dialogs' primary button.

https://caniuse.com/#search=autofocus says this should work for chrome and firefox, but not iOS Safari.

tags: added: pullrequest
Revision history for this message
Michele Morgan (mmorgan) wrote :

I haven't tested this, but I'm not in favor of the 'enter' key having the ability to dismiss dialogs.

I'd be in favor of using the spacebar to proceed, but barcode scanners are generally programmed to add an 'enter' at the end of a scan, which This could result in:

A. Users missing the pop-up alert due to a subsequent barcode scan, and also

B. Missing the barcode that dismissed the alert.

Revision history for this message
Tiffany Little (tslittle) wrote :

I agree with Michele.

Revision history for this message
a. bellenir (abellenir) wrote :

thank you for the feedback, i hadn't considered that.

here's a different patch that proceeds/confirms/continues with space only.

a button can still be activated if you press enter while the button has focus.
(that is: if you press tab to get to the button, then press enter)

Revision history for this message
Jennifer Bruch (jbruch) wrote :

This patch arose from a discussion in the Circulation Interest Group at this year's conference. I asked if anyone knew what keystroke would work on dismissing such messages because we had not found one and were having to mouse it. No one else at the discussion knew of one, perhaps not enough people there had transitioned on to webby to encounter it.

Thankfully, abellenir attended that session and was able to find the ESC key worked and he asked what keystrokes we had used in the past to handle them. In my case at circulation, the space bar and he was able to offer up a potential fix for it.

Thanks again for your interest in end-user accessibility issues abellenir!

Revision history for this message
Bill Erickson (berick) wrote :

+1 to allowing space bar to close dialogs in addition to Esc key.

Adding abellenir's patch to a working branch.

Also implementing the same logic in the Angular alert/confirm dialogs, which are (too easily) closed with a simple Enter key.

Working branch en route.

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
status: New → Confirmed
Revision history for this message
Bill Erickson (berick) wrote :

Branch w/ 2 commits as promised:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1826584-space-closes-some-dialogs

Note the Angular commit includes sandbox examples.

tags: added: angular
Changed in evergreen:
milestone: none → 3.3.2
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
milestone: 3.3.2 → 3.3.3
Changed in evergreen:
milestone: 3.3.3 → 3.3.4
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Non-Codabar barcodes can have spaces in them. This will be fun!

Revision history for this message
Michele Morgan (mmorgan) wrote :

I wonder how common it is for item barcodes that get checked out across the desk to legitimately have spaces in them.

But if we have to accommodate that possibility, perhaps we could consider an org unit setting to allow continuing past dialogs with the space bar.

Or, since barcodes that conform to the strict barcode algorithm can't have spaces, can we somehow tie the confirm with space behavior to the strict barcode workstation setting?

Adding a link to a recent IRC discussion:

http://irc.evergreen-ils.org/evergreen/2019-09-04#i_417423

I also added the accessibility tag, there needs to be a way to continue past dialogs using the keyboard.

tags: added: accessibility
Changed in evergreen:
milestone: 3.3.4 → 3.3.5
Changed in evergreen:
milestone: 3.3.5 → 3.4.2
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Changed in evergreen:
milestone: 3.4.3 → 3.4.4
Changed in evergreen:
milestone: 3.4.4 → 3.5.1
Revision history for this message
Terran McCanna (tmccanna) wrote :

Removing pullrequest and adding needsdiscussion as per comments #8 and 9.

tags: added: needsdiscussion
removed: pullrequest
Changed in evergreen:
milestone: 3.5.1 → 3.5.2
Changed in evergreen:
milestone: 3.5.2 → 3.6.1
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Changed in evergreen:
milestone: 3.6.3 → none
tags: removed: webstaffclient
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers