The Angular datepicker in the fmeditor does not go into read-only mode

Bug #1822414 reported by Jane Sandberg on 2019-03-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

Steps to recreate: create an fmeditor with a timestamp field listed as read-only

<eg-fm-record-editor #editDialog
  idlClass="bresv"
  readonlyFields="cancel_time"
</eg-fm-record-editor>

Note that the resulting fmeditor displays the datepicker and lets the user change the date just fine.

The date-select component has an input called "disabled", but none called readOnly. Perhaps the readOnly version could use the disabled version of this widget?

Revision history for this message
Bill Erickson (berick) wrote :

My plan is to give the date-select widget a readOnly mode so the value may be displayed as a string instead of a disabled selector, both for consistency and since strings are easier to read.

Changed in evergreen:
status: New → Confirmed
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Changes pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1822414-ang-date-select-disable

It includes two commits, including sandbox example.

The first commit was extracted from the working branch for bug #1821382 (formatValuePipe), so that code will need some rebasing once this is merged.

Changed in evergreen:
milestone: none → 3.3.1
assignee: Bill Erickson (berick) → nobody
tags: added: pullrequest
Jane Sandberg (sandbej) on 2019-05-17
Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
Changed in evergreen:
milestone: 3.3.1 → 3.3.2
Jane Sandberg (sandbej) on 2019-05-26
no longer affects: evergreen/3.2
Jane Sandberg (sandbej) on 2019-05-26
tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbej) wrote :

Looks great, Bill. Thanks for this! Signed off and rebased branch here: user/sandbergja/lp1822414-ang-date-select-disable

Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
importance: Undecided → Medium
Changed in evergreen:
milestone: 3.3.2 → 3.3.3
Galen Charlton (gmc) on 2019-07-31
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

I've pushed this to master after rebasing, correcting the authorship of the rebased patches, and adding a follow-up. Thanks, Bill and Jane!

I have not pushed this to rel_3_3 yet, as we have a decision to make first: whether or not to backport the bug 1831780 changes to rel_3_3. If we do, the patches for this bug that I pushed to master can be cherry-picked; if we don't, we can use the ones from Jane's signoff branch (after correcting authorship) but that will mark the beginning of a permanent divergence for data-select between rel_3_3 and master.

Changed in evergreen:
milestone: 3.3.3 → 3.4-beta1
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Revision history for this message
Jane Sandberg (sandbej) wrote :

Thanks for catching my authorship error, Galen. Taking credit for Bill's work!

I don't think there are a ton of readonly timestamp fields in the 3.3 interfaces, so I think it's okay not to backport.

Galen Charlton (gmc) on 2019-09-11
no longer affects: evergreen/3.3
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers