Web client: Patron primary and preferred prefix and suffix do not display in patron summary

Bug #1821969 reported by Michele Morgan
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.2
Fix Released
Medium
Unassigned
3.4
Fix Released
Medium
Unassigned

Bug Description

Patron records can store a primary name prefix and suffix as well as a preferred name prefix and suffix. None of these fields are displayed in the patron summary sidebar in the web client. In the xul client both prefix and suffix are displayed as part of the name in the patron summary.

A patron with name fields as follows:

prefix: Dr.
first_given_name: Henry
family_name: Jones
suffix: Jr.

Displays in the xul client patron summary as:

Dr. Jones, Henry Jr.

In the web client the patron summary shows:

Jones, Henry

Display of prefix and suffix can be important in distinguishing between patrons.

The patron summary display of both primary and preferred name should include the prefix and suffix.

Revision history for this message
Garry Collum (gcollum) wrote :

A proposed fix is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=55b14b6b37f6ad8879917593643876c8639db86b

As described above, the fix uses displays the patron information in the following pattern:

prefix family_name, given_name suffix

Changed in evergreen:
status: New → Confirmed
tags: added: pullrequest
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: none → 3.3.4
Michele Morgan (mmorgan)
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
Revision history for this message
Michele Morgan (mmorgan) wrote :

I've tested this patch and it properly displays the prefix and suffix (preferred when appropriate) in the patron summary.

My signoff branch also contains a fix for the second_given_name field, which was not displaying the primary second name if no preferred second name existed.

The branch is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1821969_signoff_and_second_given_name_fix

Changed in evergreen:
assignee: Michele Morgan (mmorgan) → nobody
tags: added: signedoff
Changed in evergreen:
milestone: 3.3.4 → 3.3.5
Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Medium
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_4, rel_3_3, and rel_3_2 (3.1.x doesn't have the preferred name feature). Thanks, Garry and Michele!

no longer affects: evergreen/3.1
Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.