fine generator: Can't call method "search_where" on an undefined value

Bug #1819796 reported by Jason Stephenson on 2019-03-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
3.1
Medium
Unassigned
3.2
Medium
Unassigned

Bug Description

Evergreen version: 3.0 to master (20190312)
OpenSRF version: 3.0+ (irrelevant)
Pg version: 9.5+ (irrelevant)
O/S version: Ubuntu 16.04 and 18.04 (irrelevant)

While looking into an issue that I believe is related to timeouts and our fine generator, I found that the open-ils.storage stderr log has thousands of messages just like this:

Caught error from 'run' method: Can't call method "search_where" on an undefined value at /usr/local/share/perl/5.26.1/OpenILS/Application/Storage/Publisher/action.pm line 1014.

Looking into the code, I see that it was modified to use a cstore editor from using storage searches back in 2014. The code to use the cstore editor when searching for booking reservations seem to suffer from a case of copy/paste-o.

Branch coming shortly.

description: updated
Jason Stephenson (jstephenson) wrote :

Here's a branch that makes the error message go away, and makes the generate fines code actually search for reservations instead of bombing out.

There are two commits. The top commit deletes the commented out code that was apparently the original implementation, and the penultimate commit removes the extraneous ->search_where from line 1014. I did this in two commits in case there is a reason for preserving the commented out code.

user/dyrcona/lp1819796-search_where

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1819796-search_where

Changed in evergreen:
milestone: none → 3.3-rc
tags: added: pullrequest
Dan Wells (dbw2) on 2019-03-13
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
assignee: Dan Wells (dbw2) → nobody
importance: Undecided → Medium
status: New → Fix Committed
Dan Wells (dbw2) wrote :

Looks good to me; pushed to master through rel_3_1. Thanks, Dyrcona, *ahem*, I mean Jason!

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers