Web client: Show Clearable holds list shows holds that can not be Cleared with the "Clear these holds" process.

Bug #1819540 reported by Dale Rigney on 2019-03-11
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned

Bug Description

Tested on Evergreen 3.2 and 3.1.10

When you click on the Holds shelf "Show Clearable Holds" tab the holds that show up include holds where the shelf_expire_time < now(). The xul client only shows holds with a shelf_expire_time < 'today'. The clear holds process only looks at holds where the shelf_expire_time < 'today'. The end results is the Show clearable Holds tab in the web client is showing holds that are not "Clearable" with the "Clear these Holds" Process. To test you can do the following:

1) Find a hold where the shelf_expire_time is earlier in the day or create one by setting the shelf_expire_time = now().
2) in the web client go to Circulation -> Holds Shelf and click on the "Show Clear Holds". You should be able to see the hold there.
3) in the xul client go to Circulation -> Browse Hold shelf and click on the View Clearable holds box. You will not see the hold listed there.
4) In the Web client click on the box for the hold in question and click on the "Clear These Holds" button.
5) Check in the item you will see the "This item should be routed to the Public Holds Shelf" window pop up for the same hold in question showing the hold was not cleared.

The web client should only show holds that are expired the day before the process is ran.

Fix is here,

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/Callender/hold_clear_list_shelf_expire_date

This change pre-loads the hold data with holds that expired less than today, not less than datetime today in order to match what the actual clear hold shelf function does. This will prevent holds from showing that won't actually clear.

It looks like this issue first showed up in 3.1.11 so it can be backported to anything above that release.

tags: added: pullrequest
removed: clear holds
Changed in evergreen:
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers