Angular experimental catalog: users can combine "Keyword" and "Starts With"

Bug #1819236 reported by Jane Sandberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

The Angular catalog has a really helpful "starts with" option that works well when searching for titles that start with a particular word. However, you can have "Starts with" and "Keyword" selected at the same time, which doesn't make much sense conceptually, and would give pretty unintuitive results to anybody who used it. The UI should prevent these two values from being selected at the same time.

Revision history for this message
Jane Sandberg (sandbergja) wrote :

The Keyword search doesn't make much sense when combined with the "Matches Exactly" operator either.

Revision history for this message
Bill Erickson (berick) wrote :

Agreed, Jane. Note the OPAC/TPAC has the same options on the advanced search page.

Revision history for this message
Bill Erickson (berick) wrote :

Fixes pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1819236-ang-cat-kw-starts-with

This 1) disables the options when keyword is selected and 2) changes the match op to the 'contains' operator in cases where it was set prior to flipping the search class selector back to keyword.

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
milestone: none → 3.4-beta2
tags: added: pullrequest
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
status: New → Confirmed
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta2 → 3.4.1
Changed in evergreen:
milestone: 3.4.1 → 3.4.2
Bill Erickson (berick)
tags: added: staffcatalog
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Revision history for this message
Ruth Frasur Davis (redavis) wrote :

I have tested this code and consent to signing off on it with my name, rfrasur, and my email address, <email address hidden>.

tags: added: signedoff
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Thanks Jane and Ruth. Merged to 3.4 and master.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.