Acquisition Patron Requests Fails Quietly if Patron has Quotes in Default Pickup Lib

Bug #1818084 reported by Robert J Jackson on 2019-02-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned

Bug Description

Noted in 3.2 webclient

When Creating a Patron Acquisition request if the patron barcode entered has a default pickup library "opac.default_pickup_location" set in actor.usr_settings with quotes around the number then the request will fail quietly.

Console shows this:

 opensrf_ws.js:46 pending count 1
opensrf_ws.js:72 pending count 1
core.bundle.js:1 No server setting type exists for eg.grid.acq.requests.list, using local value.
c.handleServerItemResponse @ core.bundle.js:1
requests.js:374 here
requests.js:439 caught TypeError: Cannot read property 'id' of undefined
    at requests.js:412
    at l (vendor.bundle.js:6)
    at vendor.bundle.js:6
    at f.$digest (vendor.bundle.js:6)
    at f.$apply (vendor.bundle.js:6)
    at HTMLFormElement.<anonymous> (vendor.bundle.js:6)
    at HTMLFormElement.dispatch (jquery.min.js:2)
    at HTMLFormElement.y.handle (jquery.min.js:2)

Line 439 is just a generic error catching line, but the error message it printed can only really apply to the aur_obj.pickup_lib().id() call on line 412:
 https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/web/js/ui/default/staff/acq/services/requests.js;h=013b083598a451dd5139da235b0a414a73dc18e7;hb=HEAD#l412

By updating the default pickup location to not contain quotes then the request will succeed.
However, new entries are created with quotes by the application.

Tags: acq Edit Tag help
description: updated
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers