Price adjustment fails for damaged items

Bug #1817952 reported by Anna Goben on 2019-02-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned

Bug Description

I thought this was already a bug, so please mark as duplicate if you can find the original.

The bill creator associated with marking an item damaged fails to accept a price adjustment. It looks like it's working fine, but when you check the actual amount assessed, it falls back to the value initially provided. See attached screencast.

Evergreen version 3.2

Anna Goben (agoben) wrote :
tags: added: billing
description: updated
Terran McCanna (tmccanna) wrote :

Hmm, we're not seeing that problem on 3.2.3. However, we have already implemented Jason Stephenson's work on this bug which I think might touch some of the same files.

https://bugs.launchpad.net/evergreen/+bug/1779467

Jason Boyer (jboyer) wrote :

I found out what was happening here. This is my fault because we don't allow users to change the billing type when charging a custom amount, and in the backend if you don't change the billing type you can't change the amount... So that's been changed locally but there's no branch to upload because it's all very localized. What I may do instead is open a new bug for discussion as to why we allow users to change the billing type at all. (You chose Damaged from the menu. It's Damaged. The end.)

Changed in evergreen:
status: New → Invalid
Terran McCanna (tmccanna) wrote :

>>What I may do instead is open a new bug for discussion as to why we allow users to change the billing type at all. (You chose Damaged from the menu. It's Damaged. The end.)<<

I don't know why it was designed that way, but my guess would be flexibility in case they wanted to add different types of damaged? Say, "Barcode replacement" vs "Broken CD case" vs. "Dropped in a fish tank" (the latter being something that a patron of mine actually did).

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers