Comment 8 for bug 1817645

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp1817645-remoteauth-patron-api-squashed-rebased has some updates:

- The code has been rebased to current master.

- A UI for managing authentication profiles has been added to the staff client.

- You can now specify a user activity type for your authentication profiles. When a user is authenticated via a RemoteAuth endpoint, the request will be recorded in user activity using the user activity type associated with that endpoint's authentication profile. (There is no new default user activity type for RemoteAuth, since different libraries will have different needs when it comes to tracking user activity.)

The admin UI is auto-generated by Angular. Unfortunately the User Activity Type selector displays the id of the various user activity types, which is not very helpful; it ought to display the label. Do we need a specialized User Activity Type component for this? How would you implement that in an auto-generated UI?

I also see two problems that appear to affect all auto-generated server admin UIs, not just RemoteAuth: (1) When the content of a previously-populated text field is deleted, the field is saved to the database as an empty string, not as a null value. (2) The tabular summary shows "Yes" for all boolean fields, regardless of the actual value.

I have not added an opt-in/opt-out setting or the ability for users to view their activity in My Account. Those would be great features, and I hope to work on them in future, but I don't think they are essential and I'd like to focus on getting the core RemoteAuth functionality committed first.