Closed Dates Editor tab missing title

Bug #1814943 reported by Terran McCanna
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
3.2
Fix Released
Low
Unassigned

Bug Description

In 3.2.2:

The Closed Dates Editor tab in the web client is missing the page title. Branch coming momentarily.

Revision history for this message
Terran McCanna (tmccanna) wrote :
tags: added: pullrequest
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

I can confirm that the page title was missing, and that the fix works to add it in. Tested on EG 3.2.3

Signoff branch at: user/stompro/lp1814943_closed_dates_page_title_signoff
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1814943_closed_dates_page_title_signoff

Josh

tags: added: signedoff
Changed in evergreen:
importance: Undecided → Low
Revision history for this message
Rogan Hamby (rogan-hamby) wrote :

Works as advertised. sign off at user/rogan/lp1814943

Michele Morgan (mmorgan)
Changed in evergreen:
milestone: none → 3.3.1
Revision history for this message
Galen Charlton (gmc) wrote :

Removing the 3.1 target, as the closed dates editor did not have an AngularJS version until 3.2.

no longer affects: evergreen/3.1
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_3, and rel_3_2, along with a follow-up that removes an ersatz ctx.page_type line. Thanks, Terran, Josh, and Rogan!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.