Tab titles

Bug #1813647 reported by James Fournie on 2019-01-28
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned
3.2
Undecided
Unassigned

Bug Description

On the angular eg2 interfaces, the title of the tab is always "AngEG". It is useful to have tabs with descriptive titles so that if you have multiple tabs open you know which is which interface.

Changed in evergreen:
status: New → Confirmed
tags: added: usability webstaffclient
Bill Erickson (berick) wrote :

I'll try to look at this soon, but wanted to note Angular6+ has a TitleService baked in. Coupled with our StringService, we should be able to provide a reasonable analog to the AngJs strings.setPageTitle() function.

Bill Erickson (berick) on 2019-01-29
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Bill Erickson (berick) wrote :

Title support added:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1813647-angular-page-titles

2 commits:

1. Adds a new <eg-title/> component for specifying titles in page templates. Values will update in real time as variables passed to eg-title update. Consistent with AngJS strings.setPageTitle(), it also supports a built in "prefix" and "suffix" structure, separated by a magical (translatable) " - ", with prefix truncation. (E.g. "Patron #123 - Checkout").

2. Add titles for auto-generated admin pages (ACQ, Booking), Workstation admin page, and the base splash page.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.3-beta1
assignee: Bill Erickson (berick) → nobody
Bill Erickson (berick) wrote :

Note if we want to back-port to 3.2, the 2nd commit will need modifying to avoid updates to the Booking admin page, which does not exist in 3.2

Dan Wells (dbw2) on 2019-02-06
Changed in evergreen:
importance: Undecided → Wishlist
Dan Wells (dbw2) on 2019-02-20
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
Dan Wells (dbw2) wrote :

This looks good to me. So long, "AngEG"! And I would be remiss to not also mention the faithful service of "HERasdfE" :)

The various versions are pushed to both master and rel_3_2. Apologies for missing the signoff on the commits in master; I henceforth acknowledge the above commits are signed off by me.

Dan

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
assignee: Dan Wells (dbw2) → nobody
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers