Angular Fieldmapper Editor should use combobox for linked fields

Bug #1811288 reported by Bill Erickson on 2019-01-10
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

Evergreen 3.2 -- Spun off from bug #1779158

When editing a field in the Angular fm-editor-component form, linked objects are represented via a traditional HTML <select> with pre-populated options. A better widget to use here would be an eg-combobox, since it supports type-ahead and optional real-time data retrieval, which is useful for very large lists of data.

Users should have the option of pre-loading values or relying on run-time lookups, depending on what makes more sense for the data type.

Users should have a way to indicate a field should use a combobox even when it's not a linked field and provide a set of canned options.

Bill Erickson (berick) wrote :

A branch to do the above and then some:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1811288-fm-editor-combobox

From the commit:

* Linked field options traditionally rendered via <select> are now rendered with an eg-combobox.
* Caller has option to force a combobox to preload values or rely solely on typehead.
* Caller has option to provide a canned list of combobox values.
 ** For non-linked fields, this has the affect of forcing a combobox.
* Caller has option to set / override which field on the linked class should searched by the typeahead
* General improvements to fm-editor form building and field options management.

======

The branch has 2 commits for this bug and its built atop the booking admin branch for bug #1809288, since it included a number of changes I wanted to build upon. The booking admin branch should be merged before (or with) this branch.

tags: added: pullrequest
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Mike Rylander (mrylander) wrote :

Bill, this will be awesome, thanks!

Question, having only scanned the code quickly: does or can it use the selector attribute from the IDL to intelligently provide access to the "friendly" field pointed thereto? IOW, can we do typeahdead of the name field when selecting, say, a copy's status in the widget that's editing an acp object? (Note: i18n complications notwithstanding...)

Bill Erickson (berick) wrote :

Mike, yes, it will use the IDL selector field by default as the search and display field for the combobox.

Bill Erickson (berick) wrote :

Branch rebased to master and merge conflicts repaired (after merge of bug #1809288)

Bill Erickson (berick) wrote :

Branch rebased post Ang7 and rxjs import repairs applied for Ang7 support.

Bill Erickson (berick) on 2019-02-05
tags: added: angular
Bill Erickson (berick) wrote :

Setting Medium importance. This bug will affect a number of others, which will have to be rebased and likely modified (and re-tested) once this bug is merged. Notably:

https://bugs.launchpad.net/evergreen/+bug/1811156
https://bugs.launchpad.net/evergreen/+bug/1807461
https://bugs.launchpad.net/evergreen/+bug/1779158

Changed in evergreen:
importance: Undecided → Medium
Galen Charlton (gmc) on 2019-02-06
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
assignee: nobody → Mike Rylander (mrylander)
Bill Erickson (berick) wrote :

Grabbing bug to rebase to master, given recent changes.

Changed in evergreen:
assignee: Mike Rylander (mrylander) → nobody
assignee: nobody → Bill Erickson (berick)
Bill Erickson (berick) wrote :

Rebased with merge conflicts resolved and forced pushed back to:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1811288-fm-editor-combobox

Note the branch now has 3 commits. The tip commit fixes an eg2 admin page bug encountered while testing this new code (commit includes test plan).

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
milestone: 3.3-beta1 → 3.3-rc
Bill Erickson (berick) wrote :

Branch rebased to current master.

Jane Sandberg (sandbej) wrote :

Signoff branch here: user/sandbergja/lp1811288-fm-editor-combobox-signoff

Thanks so much for your work on this, Bill. It will be so nice for users to have that typeahead feature!

tags: added: signedoff
Dan Wells (dbw2) wrote :

Pushed signoffs from Jane plus two bonus commits from Bill and Jason E. testing on IRC. Thanks, everyone!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers