Selfcheck: require password setting is ignored if set to "False"

[Chris Sharp]

If the "Require Patron Password" (circ.selfcheck.patron_password_required) setting for Evergreen's built-in selfcheck is set to "False", the setting is ignored because the setting check in the JavaScript only checks if there is any value. Since "False" is stored as text and not as a boolean value, the setting check always succeeds.

Branch on the way.

Evergreen 3.0 through current master
OpenSRF 3.0.1
PostgreSQL 9.5
Ubuntu 16.04

[Chris Sharp (chrissharp123)]

This should do the trick:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1810296_selfcheck_require_password_setting

[Galen Charlton (gmc)]

Might this be a local issue, Chris? circ.selfcheck.patron_password_required's datatype is bool and I'm seeing nothing in the commit history that indicates that it was ever otherwise in stock Evergreen. As is, your patch breaks the check in master.

[Terran McCanna (tmccanna)]

Not seeing this problem in stock 3.12