The sitemap_generator errors when specifying the shortname parameter

Bug #1808006 reported by Steve Callender
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Galen Charlton
3.2
Fix Released
Undecided
Unassigned

Bug Description

In 3.1 and above,

It looks like a recent change to the sitemap_generator broke the functionality when providing a shortname parameter.

Previously the script was using the asset.opac_visible_copies table referencing the circ_lib column.

Now the script uses the asset.copies_vis_attr_cache table that does not contain circ_lib.

I've corrected the script to be able to find the circ_lib from the asset.copy table.

Revision history for this message
Steve Callender (stevecallender) wrote :
tags: added: pullrequest
Revision history for this message
Geoff Sams (gsams) wrote :

I have tested this code and consent to signing off on it with my name, Geoff Sams and my email address, <email address hidden>.

Changed in evergreen:
assignee: nobody → Geoff Sams (gsams)
tags: added: signedoff
Changed in evergreen:
assignee: Geoff Sams (gsams) → nobody
Geoff Sams (gsams)
Changed in evergreen:
status: New → Confirmed
Andrea Neiman (aneiman)
Changed in evergreen:
milestone: none → 3.1.9
no longer affects: evergreen/master
Changed in evergreen:
milestone: 3.1.9 → 3.3-beta1
Galen Charlton (gmc)
tags: added: regression
Changed in evergreen:
importance: Undecided → Medium
milestone: 3.3-beta1 → 3.2.4
no longer affects: evergreen/3.2
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.2.4 → 3.2.5
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Pushed to master and rel_3_2. Thanks, Steve and Geoff!

no longer affects: evergreen/3.1
Changed in evergreen:
milestone: 3.2.5 → 3.3-rc
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.