The angular acq admin grids should include "Edit" as one of the actions in the action menu

Bug #1807458 reported by Jane Sandberg on 2018-12-07
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.2
Undecided
Unassigned

Bug Description

In the angular acq admin grids (for example, Claim Types), you can edit rows by double clicking on them. However, this is probably not immediately apparent to users, who might click on the Actions menu instead. I propose that "Edit" be added to the actions menu, and that it only be enabled when exactly one row is selected. This would make it more similar to, say, the angularjs Metabib Fields grid, which includes Edit in its Actions menu, as well as allowing the double click.

In the current master.

Changed in evergreen:
status: New → Confirmed
Bill Erickson (berick) on 2018-12-10
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Bill Erickson (berick) wrote :

Edit Select option pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1807458-admin-grid-edit-selected

From the commit:

Adds a new "Edit Selected" action to the "Actions for Selected Items" menu in the general purpose admin grid. This only visibly affects the ACQ admin grids at time of writing, but applies to all auto-generated admin grids.

Changed in evergreen:
milestone: none → 3.2.3
assignee: Bill Erickson (berick) → nobody
tags: added: pullrequest
Jane Sandberg (sandbej) wrote :

This works well for me, Bill. Thanks!

I have tested this code and consent to signing off on it with my name, Jane Sandberg, and my email address, <email address hidden>.

tags: added: signedoff
Changed in evergreen:
milestone: 3.2.3 → 3.3-beta1
Bill Erickson (berick) wrote :

See continued progress in bug #1807461.

Bill Erickson (berick) on 2019-02-05
tags: added: angular
Changed in evergreen:
milestone: 3.3-beta1 → 3.3-rc
Dan Wells (dbw2) on 2019-03-22
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
Dan Wells (dbw2) wrote :

Pushed to master and rel_3_2 with bug #1807461. Thanks, Bill and Jane!

Changed in evergreen:
assignee: Dan Wells (dbw2) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers