Vandelay record_type Authority Issues

[Kyle Huckins]

While testing bug #1779158, Bill and I discovered some issues relating to creating a session tracker. record_type pointed to an enum, vandelay.bib_queue_queue_type, which, being in relation to a bib_queue, does not support authority records. This is an issue, as it record_type should support auth as well as bib. Creating this as a separate bug from bug #1779158 as it seems like it would be problematic even outside the context of the webstaff vandelay UI

[Kyle Huckins (khuckins)]

My branch: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1806968-vandelay-record-type-sql

The fix as is changes record_type to a string constrained to "authority" or "bib," defaulting to "bib." Originally, this was tied to the enum "bib_queue_queue_type," which did not support authority records.

[Bill Erickson (berick)]

Issue and fix confirmed. I pushed a branch with signoff plus 2 commits:

1. fixes to the SQL upgrade script to remove some errant code and tweak the default record_type value.

2. Teach Vandelay.pm to pass the correct value during authority record session tracking.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1806968-vandelay-record-type-sql-signoff

[Jason Boyer (jboyer)]

Does what it says on the tin.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1806968_vandelay_record_type_signoff / working/user/jboyer/lp1806968_vandelay_record_type_signoff

[Bill Erickson (berick)]

Thanks, Jason. Mind adding a sign-off to the middle commit as well? There are 3 commits total.

[Jason Boyer (jboyer)]

Since I went to the trouble to learn how to sign off a commit other than the most recent, I added a signoff to all 3 involved and force-pushed the same branch.

[Bill Erickson (berick)]

Merged sign-off branch to master and 3.2. Thanks all!