Vandelay record_type Authority Issues

Bug #1806968 reported by Kyle Huckins on 2018-12-05
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned

Bug Description

While testing bug #1779158, Bill and I discovered some issues relating to creating a session tracker. record_type pointed to an enum, vandelay.bib_queue_queue_type, which, being in relation to a bib_queue, does not support authority records. This is an issue, as it record_type should support auth as well as bib. Creating this as a separate bug from bug #1779158 as it seems like it would be problematic even outside the context of the webstaff vandelay UI

Kyle Huckins (khuckins) on 2018-12-05
Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
Kyle Huckins (khuckins) wrote :

My branch: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1806968-vandelay-record-type-sql

The fix as is changes record_type to a string constrained to "authority" or "bib," defaulting to "bib." Originally, this was tied to the enum "bib_queue_queue_type," which did not support authority records.

Bill Erickson (berick) on 2018-12-05
Changed in evergreen:
status: New → Confirmed
Bill Erickson (berick) on 2018-12-06
Changed in evergreen:
assignee: Kyle Huckins (khuckins) → Bill Erickson (berick)
Bill Erickson (berick) wrote :

Issue and fix confirmed. I pushed a branch with signoff plus 2 commits:

1. fixes to the SQL upgrade script to remove some errant code and tweak the default record_type value.

2. Teach Vandelay.pm to pass the correct value during authority record session tracking.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1806968-vandelay-record-type-sql-signoff

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.2.3
assignee: Bill Erickson (berick) → nobody
Jason Boyer (jboyer) wrote :

Does what it says on the tin.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1806968_vandelay_record_type_signoff / working/user/jboyer/lp1806968_vandelay_record_type_signoff

tags: added: signedoff
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers