Offline: Non-cataloged types do not print description

Bug #1806783 reported by Terran McCanna
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.2
Won't Fix
Medium
Unassigned
3.3
Fix Released
Medium
Unassigned

Bug Description

Evergreen 3.2.1:

In the offline interface, non-cataloged items do not print a description on the receipt. We can add in logic saying that if there isn't a barcode, print "Non-cataloged Item", but it would be better if we could get the type of non-cataloged item that was chosen from the dropdown of non-cataloged items.

Attachment shows how non-cataloged items currently print.

Revision history for this message
Terran McCanna (tmccanna) wrote :
description: updated
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

My fix here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1806783_offline_noncat_receipt

Instead of printing nothing, it now prints 'Non-cataloged item:' and then the number of non-cataloged items checked out. (It would be better if it could print the non-cataloged item type, but I was unable to figure out how to get that without a lookup requiring an online connection, so fixing that would be a nice improvement later.)

I also took the opportunity to break the description & due date onto two lines instead of one for readability.

Image of new receipt attached to compare to prior one.

Revision history for this message
Terran McCanna (tmccanna) wrote :
tags: added: pullrequest
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: none → 3.4-beta1
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta1 → 3.4-beta2
status: New → Confirmed
importance: Undecided → Medium
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta2 → 3.4.1
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Working in PINES production for some time and I see it working on current master. Pushed to master, rel_3_3 and rel_3_4. Thanks, Terran!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.