New hold targeter filters copies by status incorrectly

[Jeff Davis]

OpenILS::Utils::HoldTargeter->filter_copies_by_status() filters copies in two steps:

(1) available/reshelving copies in $self->copies remain in $self->copies;
(2) checked-out copies in $self->copies go into $self->recall_copies.

Since the first step removes all checked-out copies from $self->copies, $self->recall_copies always ends up empty. As a consequence, it appears that no copies are ever recalled.

All supported versions of EG are affected. Fix forthcoming.

[Jeff Davis (jdavis-sitka)]

Working branch user/jeffdavis/lp1804716-hold-targeter-filter-copies-by-status has a fix:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1804716-hold-targeter-filter-copies-by-status

[Jeff Davis (jdavis-sitka)]

This only affects initial hold placement and the new hold targeter. The old (legacy) hold targeter will recall copies when it retargets a hold.

[Bill Erickson (berick)]

Issue and fix confirmed. Thanks, Jeff. Merged to 3.1, 3.2, master.