New hold targeter filters copies by status incorrectly

Bug #1804716 reported by Jeff Davis on 2018-11-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.1
Undecided
Unassigned
3.2
Undecided
Unassigned

Bug Description

OpenILS::Utils::HoldTargeter->filter_copies_by_status() filters copies in two steps:

(1) available/reshelving copies in $self->copies remain in $self->copies;
(2) checked-out copies in $self->copies go into $self->recall_copies.

Since the first step removes all checked-out copies from $self->copies, $self->recall_copies always ends up empty. As a consequence, it appears that no copies are ever recalled.

All supported versions of EG are affected. Fix forthcoming.

Jeff Davis (jdavis-sitka) wrote :
tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.3-beta1
tags: added: holds recalls
Jeff Davis (jdavis-sitka) wrote :

This only affects initial hold placement and the new hold targeter. The old (legacy) hold targeter will recall copies when it retargets a hold.

Bill Erickson (berick) wrote :

Issue and fix confirmed. Thanks, Jeff. Merged to 3.1, 3.2, master.

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
status: New → Confirmed
no longer affects: evergreen/3.2
Changed in evergreen:
milestone: 3.3-beta1 → 3.2.3
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
milestone: 3.2.3 → 3.3-beta1
status: Fix Committed → Fix Released
Changed in evergreen:
status: Fix Released → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers