Clear button does not work for Holdings Template Editor
Bug #1803584 reported by
Sarah Childs
This bug affects 5 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
3.2 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
When you are creating and editing templates in the Holdings Template Editor (former Volume/Copy Template Editor), the clear button has no discernible effects. Any templates or values which have been applied, stay applied. In the Holdings Editor it actually clears all applied values, so I would expect it to do the same in the Template Editor. In order to clear the values in the Template Editor, you currently have to refresh the page. I'm in Evergreen Indiana and experiencing this in both our live 3.1 and demo server 3.2.
summary: |
- Clear button does not work for Holdings Template + Clear button does not work for Holdings Template Editor |
tags: | added: pullrequest |
Changed in evergreen: | |
milestone: | none → 3.2.3 |
Changed in evergreen: | |
milestone: | 3.2.3 → 3.next |
Changed in evergreen: | |
milestone: | 3.next → 3.3-beta1 |
Changed in evergreen: | |
milestone: | 3.3-beta1 → 3.3-rc |
Changed in evergreen: | |
assignee: | nobody → Beth Willis (willis-a) |
Changed in evergreen: | |
status: | New → Confirmed |
Changed in evergreen: | |
assignee: | nobody → Bill Erickson (berick) |
Changed in evergreen: | |
milestone: | 3.3-rc → 3.3.1 |
Changed in evergreen: | |
milestone: | 3.3.1 → 3.3.2 |
Changed in evergreen: | |
assignee: | Galen Charlton (gmc) → Dan Pearl (dpearl) |
tags: | added: signedoff |
Changed in evergreen: | |
assignee: | Dan Pearl (dpearl) → nobody |
Changed in evergreen: | |
assignee: | nobody → Galen Charlton (gmc) |
Changed in evergreen: | |
milestone: | 3.3.2 → 3.3.3 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Looks like a reference to MultiMap was added to the wrong clearWorking() function. The template editor dies trying to clear that while it't not currently possible to clear multiple items when editing them. This fixes it:
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ jboyer/ lp1803584_ clear_editor working/ user/jboyer/ lp1803584_ clear_editor
To test:
Pre-load, go to the template editor, change anything and then click Clear. Nothing will change and if you look at the console you'll see an error about setting a property on 'undefined'.
After loading, clicking the button will clear changes to the template editor and no error will be logged (about this... there are other errors that have appeared recently but don't appear to cause problems).
After loading you'll also be able to clear all items when editing multiple. You can see this by either making massive changes to multiple items or following through the debugger and just not saving.