offline interface fails

Bug #1801156 reported by Jason Boyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
3.1
Fix Released
High
Unassigned

Bug Description

Eg 3.1

When trying to load the offline interface of a 3.1 server the following error is found in the console: "Uncaught Reference Error: UpUp is not defined" because UpUp.start is being called from the offline content, followed by an error referencing iframeResizer.min.js which should probably be listed in the UpUp assets. Later there's an error referencing angular-tablesort.js but I'm not sure that's even still used?

Eg 3.2

When trying to load the offline interface of a 3.2 server the following error is found in the console: "Error: [$compile:tpload] Failed to load template: ./share/t_org_select (HTTP status: -1)." Adding that template to the UpUp asset list corrects this.

Both errors in the end leave you with an empty Working Location list and prevent you from saving any transactions, rendering offline mode unusable.

To test offline mode I started with my browser closed, turned off the wireless, then started the browser and went to SERVER/eg/staff/. It seems that if your connection is lost unexpectedly with the browser open it may currently work but that's not reliable enough. I hope to have some branches ready soon to address these.

Revision history for this message
Jason Boyer (jboyer) wrote :

Testing please:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1801156_offline_rel_3_1 working/user/jboyer/lp1801156_offline_rel_3_1

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1801156_offline_rel_3_2 working//user/jboyer/lp1801156_offline_rel_3_2

Two branches because t_org_select doesn't mean anything < 3.2.

To test:
Login to a server that has had one of these applied. If this isn't the first time you've logged in today you'll need to delete the UpUp Application cache first, then login.
Close your browser. Shut it.
Get off the internet; turn off Wifi, unplug the cable, whatever.
Enter your server name to trigger offline mode
Try to save transactions. Pre-patch I can't do this at all, if you can post-patch, huzzah, test over.

tags: added: pullrequest
Jason Boyer (jboyer)
Changed in evergreen:
importance: Undecided → High
Galen Charlton (gmc)
Changed in evergreen:
milestone: none → 3.2.2
status: New → Confirmed
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Tested. Signoff branches are:

3.2/master: user/gmcharlt/lp1801156_signoff_3_2
3.1: user/gmcharlt/lp1801156_signoff_3_1

tags: added: signedoff
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Revision history for this message
Bill Erickson (berick) wrote :

Pushed 3.2 and 3.1 commits. Thanks!

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.